search

Esri / maps-app-ios

Your organisation's mapping app built with the Runtime SDK for iOS
Apache License 2.0
19 stars 24 forks source link

Add app documentation and supporting images #92

Closed mikewilburn closed 4 years ago

mikewilburn commented 5 years ago

This PR adds documentation that can currently be found at https://developers.arcgis.com/example-apps/maps-app-ios/ additionally to this repository. It also respects the current /docs structure that this repo follows.

esreli commented 4 years ago

@mikewilburn can you change the base branch from master to eli.patch? I wish I hadn't given the branch that name, I should have named it the patch number (doh!). This way we can wrap all of these changes into a single release.

mikewilburn commented 4 years ago

Sorry @esreli. I had intended to correct the hyperlinks after recognizing the relative paths to the Developers Site, but hadn't gotten back around to it yet. But, yes, I'll fix these 404 errors and rebase against that patch branch you specified.

mikewilburn commented 4 years ago

@esreli should be all fixed. Have another look?

mikewilburn commented 4 years ago

@esreli changes are up! Would you re-review before I merge?

mikewilburn commented 4 years ago

I believe those images are referenced in the README.md. ~I moved them to the images directory once the structure was set. Should I reverse that change?~

Edit: nevermind, that must be in a different repo's PR of mine. Looks like those images are already there in master.

esreli commented 4 years ago

Oy. Silly me. Nope, I think those are good where they are.