Closed csmoore closed 8 years ago
@csmoore I checked to see if there were any symbols with bad labeling that we missed, using Bobs list #79. There are several that he marked as wrong but appear correct after looking at the current dataset in Pro and cross checking with the standard. Therefore, I think our list of incorrectly labeled symbols is complete. Below is a list of symbols with labeling issues in #79 that did not appear here. Checked symbol ID numbers do not have any labeling issues
With this checklist accounted for we can close issue #79
Thanks for having a look & re-checking/testing these - for the overlapping/orientation label issues mentioned (260100, etc.) we'll eventually open a CR in Pro about the Maplex rules not being honored, but we'll probably hold off on that until we have all of the labels working/added.
I just noticed that this table doesn't include the static portions of the label - so when you start looking at these & fixing these symbols, just be careful to check these static labels also for each affiliation.
For example the static label "MSR" in the Main Supply Route Symbol - is missing for "Sustainment Lines : Alternate Supply Route : One Way Traffic : Hostile" (so I just added it to the table above)
@csmoore Thanks for the heads up, I've been double checking against the Standard to ensure I'm not missing any part of the label fixes, once I fix a significant portion of the labeling issues I'll start checking off this list
List checked off with significant progress on lines and areas, will tackle points next
Thanks for the update, looks like a good first cut/iteration - maybe try just a few point features just to make sure there are no issues with that type as well.
List updated to reflect changes as of end of sprint 8/11/15, with significant improvements. Fixing the remaining labeling errors (about 10% of CM symbols) will rely on resolving #104
List updated to reflect changes as of end of sprint 9/2/15, with all labels rendering properly. @csmoore verify to potentially close issue?
Sample stylx/test data you sent me looks really good - we'll just need to schedule some (large chunk of) time for someone with a fresh set of eyes (like maybe @BobBooth if available) to (arduously) verify one symbol at a time
Marking this a verified for now. Additional errors introduced found during regression testing noted in #142
Control Measure Labels have been tested by @Dbarnes1 with current mil2525d.stylx (7/7/15), MilitaryOverlay.gdb.zip (6/23/15). The table below shows symbols that have issues with missing/erroneous labels.
A Pro 1.1 Project Package (1.1.RC) with all Control Measure symbols drawn on the map, table attributes below, and Red outlining of bad labels is here: https://github.com/Esri/military-features-data/blob/v.next/data/mil2525d/sample_data/projects/ControlMeasuresAll.ppkx
Missing Echelon/Field B, also noted here: https://github.com/Esri/military-features-data/issues/66 (and is a rendering issue that may not be able to be fixed with a stylx update unless we change the current method for drawing this label)