search

Esri / military-features-data

Source data for Esri defense and intelligence feature templates. This data is used to create features and derived data products using military symbology.
Apache License 2.0
45 stars 32 forks source link

Updating incorrect Ice Flow symbol #264

Closed Dbarnes1 closed 7 years ago

Dbarnes1 commented 7 years ago

@csmoore very small change, just removing an incorrect ice flow symbol in our stylx files. I met with @jeconley this morning and her display tests showed that we removed the visibility of the symbol, we didn't actually delete it from our stylx files, so I went ahead and removed the entry.

csmoore commented 7 years ago

@Dbarnes1 - I'll open these versions just to sanity check (let me know if something else I should test) - Just some other general questions:

Are any of these recent changes things that should also be changed in lines/areas style? https://github.com/Esri/military-features-data/blob/dev/data/mil2525d/core_data/stylxfiles/mil2525d-lines-areas-labels-base-template.stylx (Note: we'll also want to upgrade this style to 2.0)

Also, (and this is a bit confusing), the style at https://github.com/Esri/military-features-data/tree/dev/data/mil2525c_b2/dictionary_renderer/mil2525c_b2 is intended for Pro 1.2 ("plugin" model) only so not sure we want to update that one.

Dbarnes1 commented 7 years ago

@csmoore in response to your questions, I don't think we'll need to make the recent changes in the lines/areas style but we should definitely upgrade it to 2.0, and I accidentally made the edit in the https://github.com/Esri/military-features-data/tree/dev/data/mil2525c_b2/dictionary_renderer/mil2525c_b2 before making it in the correct source stylx location. Is there any way we could just link the location of the source stylx to the dictionary renderer plug-in location so there aren't two (supposedly) identical stylx files that need managed?