Closed ACueva closed 6 years ago
@ACueva @nfeuerstein
I was going to start on this if we are ready - just checking back to see if:
@csmoore Reviewed some notes I wrote down, Per @nfeuerstein, we do not need to go back and add APP6 to our existing templates. She is also still waiting on the verbiage from legal.
In looking at the solutions page content for military-symbology-styles in order to add app6b.stylx back in - while we are updating this page - is there any reason to keep mentions of earlier versions of the styles?
That is earlier, than currently supported versions: Pro 1.4 & Runtime 100.0 (actually not sure what the current supported version is for Runtime?)
@Dbarnes1 @ACueva @nfeuerstein @lfunkhouser
@csmoore I'd say it'd be a good idea to just test to make sure the 1.4 style works in 2.0 and 2.1 and then put 1.4+ on there and get rid of the older styles. The mil2525c runtime 10.2.x style should stay up there, though, as I think Runtime still wants us to host that there for them. I'll post on their slack channel to check
feedback from Runtime, we should put 100.x as our supported version so we don't have to change our doc each time it updates
Just confirming (for the solution page update) for the older stylxs - app6b.stylx and mil2525c.stylx - the Runtime versions for these are 10.2.x and 100.1+ (just making sure this is correct, since a little confusing for these)?
I haven't tested those older stylx files in Runtime 100.1, so I'm not sure whether they work with both
@Dbarnes1 - They seem to work there (Runtime 100.1 screenshot below using these styles) - so assuming this is officially supported?
Do we know what build of Pro 2.1 will support these? Is there anything else we need to do on our end to make sure this happens? It would be good to test these there also.
@csmoore looks good, in that case its definitely supported. I don't think we need to do anything to make sure the stylx files work in Pro 2.1, I've been using Military Symbol editor in 2.1 and it seems to be fine, but another test definitely wouldn't hurt.
Everything should be ready to update once we have the legal/caveat wording - so marking this task impeded until we have that.
Everything we have so far (minus wording to add):
Repo Update branch: https://github.com/Esri/military-features-data/tree/csm/%23276-readd-app6b
Solutions Pages Update branch: https://github.com/csmoore/arcgis-solutions-website/tree/csm/update-military-symbology-styles
Download item text: AGSFD-DownloadItem-app6b.txt
Download item - thanks @ACueva for creating (only one on team with access) now available at: http://arcgisfordefense.maps.arcgis.com/home/item.html?id=0ca4598346be4677a869b7c639545288 ( @Dbarnes1 @joebayles can you pass this on to Pro/Runtime/Server team and let them know they can add this back in for future release )
Solutions Page PR made: https://github.com/ArcGIS/arcgis-solutions-website/pull/5800
has this style been verified to work against Runtime 100.x? I just know that the last time it was released it worked with Runtime 10.2.x
@Dbarnes1 - it requires 100.1 or later ( I used Runtime 100.1 in the screenshot above - so that is why the solution page uses this requirement for app6b/mil2525c ( 100.1 or later
and not 100.x
)
ok, thanks for explaining, sounds good!
Solutions Page PR merged - closing/complete
Reopening issue. Issues reported with the APP6B stylx being supported in Pro and Runtime.
This styleX file will only work with the symbolID code
Need to understand how this is supported in:
We need the updated style files from Runtime team to address this issue.
I am attempting to check if this is working with recent Pro 2.1 build. The steps I followed are: 1) Navigate to: C:\Program Files\ArcGIS\Pro\Resources\Dictionaries 2) Create a new folder called "app6b" in this location. 3) Copy the "app6b.stylx" ArcGIS Pro StylX file into this folder (I got this from Box, updated today by @csmoore ). 4) Open the test data Project Package (App6bComprehensiveTestDataPoints.ppkx). 5) Open the SamplePoints layer Symbology properties. I can see that APP6B is one of the dictionary options listed there - this is good, I think. 6) Select APP6B as the dictionary. No symbology update, and a warning appears: "Requested operation could not be completed." So - we need to communicate a bit more with core folks, see what the snag is, and which version of Pro this is supported at. I'm using Pro 2.1.1 from 12/29/2017.
@topowright @ACueva
Who is the POC with Pro team? Craig W? @csmoore @ACueva @topowright @dfoll
So, I emailed Kerry and Ralf about this. Kerry is out till 1/5. Will see if Ralf has any info.
Ralf says he is seeing this behavior on Pro 2.2 build 11338.
@csmoore - when I try setting the symbology of the sample points (the ones that start of as generic features) to Dictionary Renderer, I get the same error message.
I think @csmoore can confirm, but at Pro 2.1 this workflow is no longer supported. This is an intentional change that core made. Any New supported dictionaries will have to be approved through the pro team.
From: Bob Booth notifications@github.com Sent: Wednesday, January 3, 2018 10:42:01 AM To: Esri/military-features-data Cc: Daniel Barnes; Mention Subject: Re: [Esri/military-features-data] Re-release APP6B for ArcGIS (#276)
I am attempting to check if this is working with recent Pro 2.1 build. The steps I followed are:
@topowrighthttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_topowright&d=DwMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=5UWGVEuan5dOgBanmf_Kw5lHBN92ttL9FFakGmdre5M&m=arG1FLBCkPOhI_YY0JFS7T8BLoFap_0vWUkBbKg85dk&s=UK9GQgRMsVUzgTD83eEQDASULxuWUEp2qxi7ssUfjrs&e= @ACuevahttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_acueva&d=DwMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=5UWGVEuan5dOgBanmf_Kw5lHBN92ttL9FFakGmdre5M&m=arG1FLBCkPOhI_YY0JFS7T8BLoFap_0vWUkBbKg85dk&s=J_oSb7gf3R7VtCjf1ijRXXJ7clSXc8yw6RdUFU_HxaQ&e=
- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Esri_military-2Dfeatures-2Ddata_issues_276-23issuecomment-2D355091759&d=DwMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=5UWGVEuan5dOgBanmf_Kw5lHBN92ttL9FFakGmdre5M&m=arG1FLBCkPOhI_YY0JFS7T8BLoFap_0vWUkBbKg85dk&s=RvzXzaMelkVpwSNvjK7_KcAxiYKIC_XmHAhsbbS67Fs&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMa8ZcxNXvBgUAqhOQpbgULH-2DHhNYiH7ks5tG8n5gaJpZM4P5CvC&d=DwMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=5UWGVEuan5dOgBanmf_Kw5lHBN92ttL9FFakGmdre5M&m=arG1FLBCkPOhI_YY0JFS7T8BLoFap_0vWUkBbKg85dk&s=AUfBx1S0KG0kXzuRYV41jh6k7xGwJw1qEBwPrTOd5nQ&e=.
@BobBooth are you testing from the new files that we received from core?
@Dbarnes1 - I was trying to test whether the new stylx would work with Pro 2.1 - is it the case that the only way APP6B could work in Pro 2.1 would be with some other core modification? Do you know what the workflow would be? @topowright - yes, tested with the one @csmoore put on box, then, working with Ralf, tested with one he shared with me from his machine (the one Chris got it from, by the name). Same result both times.
@lfunkhouser currently the file that was given to us does not work in ArcGIS Pro 2.1 and we are not sure what version of Runtime this would work on. We need to follow up with this issue to understand when we will be able to finish this work.
I emailed runtime & cc'd team to let them know that using Runtime 100.2 and latest stylx only a small number of the features seem to show a symbol.
Here is what I tried:
Screenshot in ArcMap vs. Runtime (note ArcMap symbols are just simple/notational/not APP6 – but show where a symbol should be):
This is the current behavior I get when dealing with the stylx file is captured in the image below. However, I also do not see the correct behavior for the other stylx files that are included in side of ArcGIS Pro. I also need some guidance on symbology. @csmoore @lfunkhouser I do not see a 2525Bc2 option in core, which I think needs to be there based on the conversations that have happened in the past. I see 2525D and 2525cb2, which confuses me and I think would confuse our customers. I am not sure why the same styles that are in Military Symbol Editor are not supported in core. @lfunkhouser you started to talk about this yesterday, but I am still confused.
Last comment was copied from two days ago, which I made in another issue that is now closed. That issue is issue : #281
I am currently working on build 10257 and this is what I see when I try to populate symbology using the stylx for APP6B.
@topowright - you may have to remove the app6b file/folder for the others to work correctly
I also seem to be having a problem with other functionality with the other dictionaries.
@Dbarnes1 - does the Pro team have to ship the stylx, and/or do something else to enable it?
@BobBooth if you get a completely fresh install of Pro 2.1, I believe the only .stylx files you'll get are 2525c_b2 and 2525d, which cover 2525B Change 2, 2525C, and 2525D.
Back in the Pro 1.0-1.2 days, there was a workflow where you could take your own code for a dictionary renderer (APP6B) and the stylx and copy/paste that into your install dictionaries folder for Pro in order to get it to work. As of Pro 1.3, that workflow was shut down and any additions to supported dictionaries had to be shipped with Pro. We had to work hand in hand with Pro in order to ship 2525c_b2 at Pro 1.4+. I haven't been that closely plugged in to releasing our APP6B stylx at Pro 2.1 or 2.2, but I'm pretty sure that they would have to ship it with core. It looks like the APP6B stylx was released at Runtime 100.2? If it is in Runtime, my understanding is that Pro can pick it up and surface it in the Symbology pane with a relatively low level of effort, but the Pro team definitely needs to "turn the switch" to get that functionality in.
The multiscale mapping team has a PBI for adding support for APP6B. It is https://devtopia.esri.com/ArcGISPro/multiscale-mapping/issues/374.
We will need to grab some updates from runtime before we can consume this. Also we will need the most up to date dictionary and test data.
Is https://github.com/Esri/military-features-data/blob/dev/military-symbology-styles/app6b/app6b.stylx the correct dictionary to grab?
Is there test data that I can add to the Pro test harness? I have the pairwise data for the other dictionaries that allows us to test the drawing of all the symbols to ensure there are no regression.
@jeconley previous comment is correct, except the updated stylx file is not located in the directory above. Instead, it is attached to the issue in Devtopia.
I was testing with build 10247 last month (Dec 14) and was able to create a folder named 'app6b', copy the updated style file in it, and successfully select it in the drop down list of dictionaries (sic was the only available field listed, as expected). Today I tried again using the same build (10247) and I see the same issue Bob is reporting. I do not see this issue if I remove the app6b folder. I'm not sure what could have changed since then.
Runtime 100.2 did not ship with the app6b style file, but we have confirmed that it will work with the latest version (as will 100.1).
@kerryrobinson - I wasn't able to get a simple runtime (.NET) app6b sample to work (in 100.1 or 100.2) using the latest stylx ralf provided. Only some of the symbols seemed to draw - is there someone who can look at the sample to see if I am doing something wrong. The sample is here: https://esri.box.com/s/dt7ejubj12h566mabxotvk1l0fwh4og9
There will be no APP6B support for ArcGIS Pro until version 2.2 .
We will need to update the AGO item to allow customers to use this capability in ArcGIS Runtime 100.2
This issue needs to split this into two different issues:
Additional note for runtime testing/support:
I've updated the app6b test data in: #289
And the runtime data loader sample app (using 100.2) at: https://esri.box.com/s/dt7ejubj12h566mabxotvk1l0fwh4og9
Using the sample app (and ArcMap data creation steps in sample app readme) - you should be able to create and view sample data in Runtime.
Here is how the comprehensive data set looks in the sample app (about 3% of the symbols showing as unknown at this point):
@csmoore Do we think that 3% are invalid symbol IDs or symbols which need to be fixed in the style file?
@kerryrobinson - for the yellow clovers, probably a bad style entry - though we can't completely rule out a problem with out truth data or drawing, but once we can edit/see data in Pro - it will probably be much easier to see what is going on.
I have grabbed the test app https://esri.box.com/s/dt7ejubj12h566mabxotvk1l0fwh4og9 and run it successfully on my machine.
I checked the quatrefoil symbols and the features that were not drawing at all in the runtime app against a version of the data in ArcMap and against the APP6B standard PDF. https://github.com/Esri/military-features-data/wiki/Issues-with-APP6-B-symbols-identified-using-Runtime-app-Xref-with-ArcMap-and-PDF-of-standard
Currently our stylx file does not draw correctly in ArcGIS Pro and ArcGIS Runtime
Since the app6b style file that is currently published here http://solutions.arcgis.com/defense/help/military-symbology-styles/ doesn't work with Runtime 100.1+ as advertised, can we remove this reference until we've uploaded a version that does?
@kerryrobinson We need to get a better understanding of what symbols aren't drawing and how to test this better. 100.1 is supported with issues; however, the list of known issues needs to be better understood.
@lfunkhouser @kerryrobinson
The latest/current version of the app6.stylx that we were provided by Runtime is currently here - it is not yet posted to the stylx download page but likely will be this version
One important note - This stylx is set to CIM 2.1 so will only work on Runtime 100.2 or later. If this is a problem and you also want to support 100.1 we should probably address/fix this before we start making fixes/changes.
You get the error below if you try on 100.1:
Style file Military Features
Put Data back into Military Features Template- (Follow up with @nfeuerstein )Put the APP6 option back into the Military Features Tools