search

Esri / military-features-data

Source data for Esri defense and intelligence feature templates. This data is used to create features and derived data products using military symbology.
Apache License 2.0
46 stars 32 forks source link

Remove all spaces after semi colons in the APP6-B STYLX #291

Closed BobBooth closed 6 years ago

BobBooth commented 6 years ago

Issues identified during a review of APP6B symbols not drawing in the runtime app, probably due to issues with the STYLX. Comprehensive test data at: https://github.com/Esri/military-features-data/tree/dev/military-symbology-styles/test-data/app6b Used Runtime app created by @csmoore, from his comment on https://github.com/Esri/military-features-data/issues/276 "... And the runtime data loader sample app (using 100.2) at: https://esri.box.com/s/dt7ejubj12h566mabxotvk1l0fwh4og9

Using the sample app (and ArcMap data creation steps in sample app readme) - you should be able to create and view sample data in Runtime.

Here is how the comprehensive data set looks in the sample app (about 3% of the symbols showing as unknown at this point): ..."

I test-loaded a more recent version of the comprehensive test data using ArcMap 10.6.0.8321 and the latest released Military Features APP6B styles from here http://solutions.arcgis.com/defense/help/military-features/ and I am seeing a different set of issues, described here: https://github.com/Esri/military-features-data/pull/292#issuecomment-358804132 (includes lists of loading errors and PDFs of point, line, and area symbols as they draw in ArcMap).

Brief summary of issue encountered:
Attributes   from Comp Test Data Image from Standard Description From Standard Heirarchy Sym-ID Actual Standard Note
-- PlaceholderImage -- -- -- -- --
OID   766     Shape Point     sic GFCPBOAIC------     Label COMPLETED MINEFIELD image Completed Minefield 2.X.2.2.1.6.2 GCBOAIC- Just a box drawing Should be  box with   three empty circles.
OID   765     Shape Point     sic GFCPBOAIP------     Label PLANNED MINEFIELD image Planned Minefield 2.X.2.2.1.6.1 GCBOAIP- No symbol drawing at all Should be dashed  box   with three empty circles.
OID   189     Shape Point     sic SFGPUCFRS------     Label SINGLE ROCKET LAUNCHER image FIELD ARTILLERY     ROCKET     SINGLE ROCKET     LAUNCHER 1.X.3.1.1.7.2.1 SGUCFRS-***** image  
OID   207     Shape Point     sic SFGPUCFMSW-----     Label SP WHEELED MORTAR image FIELD ARTILLERY     MORTAR     SP WHEELED 1.X.3.1.1.7.4.2 SGUCFMSW***** image  
OID   237     Shape Point     sic SFGPUCRLL------     Label RECONNAISSANCE LIGHT image RECONNAISSANCE     LIGHT 1.X.3.1.1.8.7 SGUCRLL--***** image  
OID   358     Shape Point     sic SFGPUSAW-------     Label MORAL WELFARE RECREATION (MWR) image ADMINISTRATIVE     MORAL,     WELFARE,     RECREATION (MWR) 1.X.3.1.3.1.12 SGUSAW--***** Yellow Quatrefoil -   
OID   359     Shape Point     sic SFGPUSAWT------     Label MWR THEATRE image ADMINISTRATIVE     MORAL, WELFARE,     RECREATION     THEATRE 1.X.3.1.3.1.12.1 SGUSAWT-***** Yellow Quatrefoil -    
OID   360     Shape Point     sic SFGPUSAWC------     Label MWR CORPS image ADMINISTRATIVE     MORAL, WELFARE,     RECREATION     CORPS 1.X.3.1.3.1.12.2 SGUSAWC-***** Yellow Quatrefoil -   
OID   535     Shape Point     sic SFGPEVATW------     Label TANK LIGHT RECOVERY image TANK LIGHT     RECOVERY 1.X.3.2.2.1.1.1.1 SGEVATW-***** Yellow Quatrefoil -   
OID   537     Shape Point     sic SFGPEVATX------     Label TANK MEDIUM RECOVERY image TANK MEDIUM     RECOVERY 1.X.3.2.2.1.1.2.1 SGEVATX-***** Yellow Quatrefoil -   
OID   539     Shape Point     sic SFGPEVATY------     Label TANK HEAVY RECOVERY image TANK HEAVY     RECOVERY 1.X.3.2.2.1.1.3.1 SGEVATY-***** Yellow Quatrefoil -    
OID   701     Shape Point     sic SFUPNBR--------     Label SEABED ROCK/STONE OBSTACLE OTHER image SEABED     ROCK/STONE,     OBSTACLE, OTHER 1.X.5.4.2.2 S-U*NBR---***** Yellow Quatrefoil - Should be a solid black version of NBS  
OID   702     Shape Point     sic SFUPNBW--------     Label WRECK image WRECK 1.X.5.4.2.3 S-U*NBW---***** Yellow Quatrefoil -Wreck symbol from   standard +++ not drawing.  
OID   703     Shape Point     sic SFUPNM---------     Label MARINE LIFE image MARINE LIFE 1.X.5.4.3 S-U*NM----***** Yellow Quatrefoil -Marine life symbol from   standard not drawing.  
OID   704     Shape Point     sic SFUPNA---------     Label SEA ANOMALY image SEA ANOMALY 1.X.5.4.4 S-U*NA----***** Yellow Quatrefoil - Sea Anomaly stacked, M   shaped pair of wavy lines not drawing  
OID   767     Shape Point     sic GFCPBOAIN------     Label ANTITANK (AT) MINEFIELD image Antitank (AT) Minefield 2.X.2.2.1.6.5 GCBOAIN- No symbol drawing at all  
OID   768     Shape Point     sic GFCPBOAIS------     Label SCATTERABLE MINES image     BOAIS-  No symbol drawing at all  
OID   769     Shape Point     sic GFCPBOAIH------     Label ANTIPERSONNEL (AP) MINEFIELD REINFORCED WITH SCATTERABLE WITH   SELF-DESTRUCT DATE-TIME-GROUP image      BOAIH- No symbol drawing at all  
OID   770     Shape Point     sic GFCPBOAID------     Label SCATTERABLE MINEFIELD WITH SELF-DESTRUCT DATE-TIME-GROUP image     BOAID-  No symbol drawing at all  
OID   771     Shape Point     sic GFCPBOAV-------     Label EXECUTED VOLCANO MINEFIELD image Executed Volcano Minefield 2.X.2.2.1.7 GCBOAV-- Green version of the   symbol is drawing, missing line/pointer below it.  
OID   775     Shape Point     sic GFCPBSW--------     Label FOXHOLE EMPLACEMENT OR WEAPON SITE image Foxhole, Emplacement, or Weapon Site 2.X.2.2.3.4 GCBSE--- Tactical graphic not   drawing. Should be rectangle with open bottom.  
OID   778     Shape Point     sic GFCPBWM--------     Label MINIMUM SAFE DISTANCE ZONES image Minimum Safe Distance Zones 2.X.2.2.4.1 GCBWM--- This is a set of rings, maybe we're drawing with lines/polys?  
OID   928     Shape Point     sic GFOPPHG--------     Label WRITTEN PROPAGANDA image Written Propaganda 2.X.3.3.6.3 GFO*PHG--- Should be unknown   quatrefoil with W and Propaganda sumbol, like GFOPPHW--------  
OID   922     Shape Point     sic GHOPPCU--------     Label RECRUITMENT (COERCED/IMPRESSED) image Recruitment (coerced/impressed) 2.X.3.3.3.1 GHO*PCU--- Should be ENY frame with   person symbol with C over it (like GHOPPC, but with C instead of W)
OBJECTID   63     SHAPE Polyline     OID 63     Annex E     Affiliation Hostile     Full SIDC GHCPMOLAE------     SIDC By Parts G H C P MO LA E- -- -- -     Hierarchy Code 2.X.2.1.5.2.1.7     Name ENEMY CONFIRMED     Geometry LINE     Notes      SHAPE_Length 312208.9578     sic GHCPMOLAE------ image Enemy Confirmed (axis of advance - enemy confirmed) 2.X.2.1.5.2.1.7 GHC*MOLAE- Double line arrow labeled   ENY on lines not drawing between endpoints.  
OBJECTID   64     SHAPE Polyline     OID 64     Annex E     Affiliation Hostile     Full SIDC GHCPMOLAT------     SIDC By Parts G H C P MO LA T- -- -- -     Hierarchy Code 2.X.2.1.5.2.1.8     Name ENEMY TEMPLATED     Geometry LINE     Notes      SHAPE_Length 312208.9578     sic GHCPMOLAT------ image Enemy Templated (axis of advance - enemy templated) 2.X.2.1.5.2.1.8 GHC*MOLAT- Double line dashed arrow   labeled ENY on lines not drawing between endpoints.  
 image Search Area/Reconnaissance Area 2.X.2.1.1.3.2.5 GCMGASS-***** No Symbol Drawn  
BobBooth commented 6 years ago

@csmoore @topowright @dfoll @ACueva

lfunkhouser commented 6 years ago

@BobBooth Please add additional information to this issue. Add the link to the "Comp Test Data" that is referenced in the table. Add more information as to what Runtime version you tested this on. Add the screenshots of both the expected symbol and the symbol that is rendered in Runtime in your issue. Do these same symbols render correctly using the style file in the ArcMap solution?

BobBooth commented 6 years ago

Overlapping set of problems detected in ArcMap using the Military Features Append Military Features Workspace tool. The tool ran on import of the Comprehensive test data, but reported errors. I scraped the errors out and matched them to the APP6B standard PDF, details at: https://github.com/ArcGIS/solutions-defense/issues/565

csmoore commented 6 years ago

@topowright - there are a few different image compare tools and ways to approach this. But this one might be good if you go with an HTML image table approach. This might justify creating a new issue to capture this testing capability.

csmoore commented 6 years ago

Moved in progress for QA task to create and doc app to export images and create verification table

csmoore commented 6 years ago

Removing QA label:

Added style to SIDC image export test app at: https://github.com/Esri/military-features-data/wiki/Runtime-Test-Apps

And used app to create a more complete set of Image Test Outputs for App6b from the style file:

Just the issues observed (about 20 symbols aren't being created): https://github.com/csmoore/mil2525-testing/blob/add-app6b/app6b/App6b-Test-Results-Issues-Only.md

The entire set of symbols: https://github.com/csmoore/mil2525-testing/blob/add-app6b/app6b/App6b-Test-Results.md

This independently confirmed what @BobBooth reported above with the exception of the minefield control measures. It looks like the style is expecting these to be polygon symbols and we had these as point symbols in the truth and test data. The depiction and geometry type of the mines/minefield symbols has been the source of confusion for some time. An attempt to clarify this is in CP 16-018-AR for 2525DChange1, App6D.

kerryrobinson commented 6 years ago

We found something else in our testing. All tags in this style file are preceded with a space (there is a space after each semicolon). This makes it difficult to search for specific tags in Runtime, and is inconsistent with the 2525[x] stylx files:

APP-6(B); Annex E; Tactical Graphics; Control Measures; Command and Control; Special Point; Air Control; Corridor Tab; Friendly; GFCPOXAD--*****

image

We should remove these spaces before publishing the file is possible.

csmoore commented 6 years ago

@kerryrobinson - that is a simple fix ( ex. UPDATE ITEMS SET TAGS = REPLACE(TAGS, '; ', ';') ), this fix is included with #294

lfunkhouser commented 6 years ago

@dfoll @ACueva @topowright Please read all comments in this issue, understand the issue, and identify the remaining work that needs to be completed.

BobBooth commented 6 years ago

Many of these are fixed in https://github.com/Esri/military-features-data/issues/85 and https://github.com/Esri/military-features-data/issues/88 @lfunkhouser @dfoll @ACueva @topowright

BobBooth commented 6 years ago

Updates to stylx and to comprehensive test data (some sidcs wrong). Includes fixes for: image.png

BobBooth commented 6 years ago

image.png Written propaganda, Enemy Main Axis of Advance Templated, Confirmed, Jamming, Composite fixes.

BobBooth commented 6 years ago

Image output for all symbols in this issue. image Issue291_test.zip Test bat file to generate these images.

topowright-zz commented 6 years ago

I am moving this to done being that it seems like this issue has a perpetual title that really does not allow us to understand what is next or what has been done. If this is not correct @dfoll @BobBooth @csmoore @ACueva I suggest we open other very clear small effort items to address what is needed.

topowright-zz commented 6 years ago

This issue can be moved to done once this pull request has been reviewed: https://github.com/Esri/military-features-data/pull/328