search

Esri / military-features-data

Source data for Esri defense and intelligence feature templates. This data is used to create features and derived data products using military symbology.
Apache License 2.0
46 stars 32 forks source link

APP-6(D) Dictionary/Stylx #293

Closed lfunkhouser closed 6 years ago

lfunkhouser commented 6 years ago

Support for APP-6(D) is needed for compliance with NATO systems. The APP-6(D) dictionary will support Runtime and ArcGIS Pro.

(Updated with potential tasks/plan)

Preparation

Stylx (Icons)

Stylx (Labels)

Dictionary Renderer

The other tasks below are not needed for the stylx creation, but are part of testing the overall solution

GDB

Military Overlay

Pro Symbol Editor

csmoore commented 6 years ago

@lfunkhouser @joebayles - do we have:

  1. The final version of the standard (or is Study Draft 2, JUNE 2016 the final version)
  2. A list of differences from 2525D
  3. The image files (SVGs) that were added to/changed in the APP-6D Version 1 from 2525D final?

I believe the added image files were confined to:

  1. New Dismounted Individual symbol set
  2. Symbol set/battle dimension frames that changed
  3. Some symbol differences

This question might be premature, but thought I'd ask just in case there is a long lead time requesting/obtaining

joebayles commented 6 years ago

@csmoore we have the final version of APP-6D in Box. I believe you are correct with everything else. Check https://github.com/Esri/joint-military-symbology-xml/pull/396 for the SVGs.

csmoore commented 6 years ago

Just to update this task - when I looked this a couple weeks ago - here is what I found and updated

The changes from 2525D.0 (06/2014) to App6D.1 (10/2017) that were readily identifiable by just skimming the standard were:

  1. Small Changes to the labels associated with each symbol set (screenshot below). Ex. country label added
  2. Addition of Dismounted Individual Symbol Set (Set 27)
  3. Addition of a new Dimension/Identity Frame Type for Dismounted Individual (Hexagon Frame for Friendly)
  4. Addition of a new Echelon Mobility Amplifier (SIDC Digits 9 & 10) for Dismounted Individual Leadership Indicator

While I was reviewing his, I went ahead and made the data updates I thought would be required for items 2-4) in branch: https://github.com/Esri/military-features-data/tree/csm/app6d-dev - To see/understand the primary changes needed, look at this commit: https://github.com/Esri/military-features-data/commit/615e4b05dd29376fefd22da8a488520d20d6e179

So this should be ready to at least attempt going through the process of creating the style and datamodel/GDB with this branch.

Also while reviewing the PR mentioned above I noticed some issues that might prevent using the JMSML source data - https://github.com/Esri/joint-military-symbology-xml/pull/396#issuecomment-361315594 but that repo/data is not needed at this time with the manual changes made in https://github.com/Esri/military-features-data/commit/615e4b05dd29376fefd22da8a488520d20d6e179

Example Frame Label Differences:

image

csmoore commented 6 years ago

Note: Updated the original issue comment above with high-level plan, potential subtasks, etc.

csmoore commented 6 years ago

This is in the Sprint plan so going to move in progress and verify there are no issues creating a style with the latest SVGs using Pro only.

lfunkhouser commented 6 years ago

@csmoore This is an epic and needs to be broken down into issues not just pulled in and worked on. There is no understanding among the team of what this issue means. The high-level plan needs to be broken down into manageable issues that can be worked on and closed out.

csmoore commented 6 years ago

@lfunkhouser - OK - I was just going to work on the first task above "Update stylx creation process to use Pro 2.0" but can wait until this complete item is planned+ready to work on - moving task back

topowright-zz commented 6 years ago

This issue was moved to Esri/military-symbology#288