search

Esri / military-features-data

Source data for Esri defense and intelligence feature templates. This data is used to create features and derived data products using military symbology.
Apache License 2.0
46 stars 32 forks source link

Using Pro 2.2, some of the 2525D Source SVGs are failing to import into Pro Styles #334

Open csmoore opened 6 years ago

csmoore commented 6 years ago

Summary of Issue Encountered:

Starting at Pro 2.2, some of the 2525D Source SVGs are failing to import into Pro Mobile Styles. The failing SVGs seems to have empty Path elements.

Brief summary of issue encountered:

After installing Pro 2.2 and attempting to load the following SVGs from: https://github.com/Esri/military-features-data/tree/dev/military-symbology-styles/utils-and-source-data/svg

svg\Appendices\Space\05120400.svg svg\Appendices\Land\20120201.svg svg\Appendices\Activities\40131202_0.svg svg\Appendices\Activities\40131202_1.svg svg\Appendices\Activities\40131202_2.svg svg\Appendices\Activities\40131202_3.svg svg\Appendices\Atmospheric\45162101.svg svg\Legacy\2525C\S-G-UCDMM-_2.svg svg\Legacy\2525C\S-G-UUMSEJ_0.svg svg\Legacy\2525C\S-G-UUMSEJ_1.svg svg\Legacy\2525C\S-G-UUMSEJ_2.svg svg\Legacy\2525C\S-G-UUMSEJ_3.svg

A failure is encountered:

image

Describe the product and version used:

Pro 2.2

Reproduction Steps and/or Where to Obtain Test Data:

Step-by-step description of how to reproduce the issue and the expected results:

  1. Create or use and exiting Pro Mobile Style
  2. Create a new symbol in the style
  3. Click on the layer properties for the new symbols and
  4. Load a Shape Marker from file using one of the files above, ex: https://github.com/Esri/military-features-data/tree/dev/military-symbology-styles/utils-and-source-data/svg/Appendices/Space/05120400.svg

You receive an error:

image

Additional information or sample data:

If you look at the failing symbols in an SVG Editor you can see that failing elements/artifacts - these are indeed empty/spurious path elements, but it would be best if Pro could just ignore these. Otherwise we should fix the source symbols to remove these paths (Note: the symbol do import fine if you remove these spurious elements).

image

image

Just to summarize this requires a fix in either:

  1. Pro to ignore these elements -or-
  2. The SVGs to remove these unused/bad paths

FYI @ACueva @dfoll @lfunkhouser @topowright

topowright-zz commented 6 years ago

This issue was moved to Esri/military-symbology#284