search

Esri / military-features-data

Source data for Esri defense and intelligence feature templates. This data is used to create features and derived data products using military symbology.
Apache License 2.0
46 stars 32 forks source link

Fix anti-tank ditch symbol (backward teeth) #37

Closed csmoore closed 9 years ago

csmoore commented 9 years ago
2525C ID 2525D ID Status Title Full Support Issue Description Link
GFMOADC----*X 25290202 Needs fixed in data NIM097957 The Antitank Ditch MIL2525C symbol orientation is incorrect in ArcGIS Runtime SDK 10.2 for Java https://github.com/Esri/military-features-data/issues/16 runtimecore/cim_rule_engine/issues/39 runtime/java-se-api/issues/761 https://github.com/Esri/military-features-data/issues/24

Update: Moved to #146:

These are the data/style-related open support tickets that are still issues in the 2525D(Delta) Stylx/dictionary.

2525C ID 2525D ID Status Title Full Support Issue Description Link
WAS-WP----P---- 45140200 Needs investigated Wind Plot - NIM097965 The MIL2525C symbols appear to be incorrect in ArcGIS Runtime SDK 10.2 for Java according to the specifications of some of the symbols runtime/java-se-api/issues/765 runtimecore/cim_rule_engine/issues/37
WA-DIPFF---L--- 45180700 Needs fixed in data Operator-Defined Freeform - NIM097965 The MIL2525C symbols appear to be incorrect in ArcGIS Runtime SDK 10.2 for Java according to the specifications of some of the symbols (polygon symbol missing) runtime/java-se-api/issues/765
WOS-HHDR---L--- 46120512 Needs fixed in data Reef Line Fails to Render (Line symbol missing)
WOS-HALH--P---- 46120409 Needs fixed in renderer plugin NIM102180 LIGHTHOUSE does not match Mil2525C specification from MessageProcessor, still drawing with 2525C version of symbol for some reason runtime/java-se-api#783 https://github.com/Esri/military-features-data/issues/24

(Note: the links above are not all publicly accessible but are provided for support purposes)

csmoore commented 9 years ago

I retested the above with Pro 1.0 - mil2525 dictionary/renderer and updated the original list - these items were removed:

2525C ID 2525D ID Status Title Full Support Issue Description Link
WA-DWS-----L--- 45140400 Fixed NIM102738 A message processor Component failed to render symbol correctly for METOC.AMPHC.WND.SMLNE as per MIL2525C specification runtime/java-se-api/issues/807runtimecore/cim_rule_engine/issues/51
WA-DWJ-----L--- 45140300 Fixed NIM102740 A message processor component failed to render symbol correctly for METOC.AMPHC.WND.JTSM as per MIL2525C specification /runtime/java-se-api/issues/808 /runtimecore/cim_rule_engine/issues/50
WO-DMCA----L--- 46160100 Fixed Submarine Cable - NIM097965 The MIL2525C symbols appear to be incorrect in ArcGIS Runtime SDK 10.2 for Java according to the specifications of some of the symbols runtime/java-se-api/issues/765runtimecore/cim_rule_engine/issues/37
GFMPOFS---****X ? Fixed Minefield graphics not working runtimecore/cim_rule_engine/issues/59 runtime/dotnet-api/issues/753
WO-DL-RA---L--- 46150300 Fixed NIM102745 A message processor fails to render symbol correctly for METOC Restricted Area under MIL-STD-2525C specification runtimecore/cim_rule_engine/issues/52 runtime/java-se-api/issues/810

Screenshots / Notes:

Stream Line/Jet Stream: image

Submarine Cable: image

Restricted Area - NOTE: the feature geometry for this symbol is LINE image

Minefield - NOTE: in 2525D Mine Area and Mine Type are separate symbols image

csmoore commented 9 years ago

METOC errors removed from this issue since a repeat of #146 & changing the tile just to "Fix Anti-tank Ditch" since that is the only issue remaining (just in runtime). Also assigning to @Dbarnes1

Dbarnes1 commented 9 years ago

image I reversed the teeth on Antitank Obstacles : Completed Entity Code 290202 to fit with the standard. @csmoore This can be verified when I PR the latest version of Mil2525D.stylx

Dbarnes1 commented 9 years ago

@BobBooth we're you able to verify that this is fixed in my latest PR?

BobBooth commented 9 years ago

@Dbarnes1 - yes, I confirm the anti tank obstacle teeth point up when you digitize a feature from left to right (and down when right to left).