search

Esri / military-features-data

Source data for Esri defense and intelligence feature templates. This data is used to create features and derived data products using military symbology.
Apache License 2.0
46 stars 32 forks source link

BUG-000088381 APP6B issue in 1.x.3 GROUND TRACK #85

Closed caporossi closed 6 years ago

caporossi commented 9 years ago

We are reviewing all the symbols represented dall'App6B and I would like to present in this repository the various issue that we find for 1.x.3 Ground Track. The tests were carried out with: • ArcGIS Runtime SDK for Java 10.2.4 • dictionary app6b.dat version 1390944071 The families of symbols as grouped in the same Hierarchy find in APP-06 (B) Joint Symbology.pdf • 1.x.3 Ground Track

Description Hierarchy Sym-id Symbol (atteso) Simbol (visualizzato) Note
MEDEVAC ROTARY WING 1.X.3.1.1.4.2.6 SFG-IBN---H---- image001 image002 The symbol appears smaller
SINGLE ROCKET LAUNCHER 1.X.3.1.1.7.2.1 SFG-UCFRS------ image009 image010 The symbol appears as a generic symbol
SP WHEELED MORTAR 1.X.3.1.1.7.4.2 SFG-UCFMSW----- image011 image010 The symbol appears as a generic symbol
RECONNAISSANCE LIGHT 1.X.3.1.1.8.7 SFG-UCRLL------- image012 image010 The symbol appears as a generic symbol
LANDING SUPPORT 1.X.3.1.2.6 SFG-UUX-------- image013 image010 The symbol appears as a generic symbol
MORAL, WELFARE, RECREATION(MWR) 1.X.3.1.3.1.12 SFG-USAW------- image016 image010 The symbol appears as a generic symbol
MWR THEATRE 1.X.3.1.3.1.12.1 SFG-USAWT------ image017 image010 The symbol appears as a generic symbol
MWR CORPS 1.X.3.1.3.1.12.2 SFG-USAWC------ image018 image010 The symbol appears as a generic symbol
UNIT GENERAL LIAISON 1.X.3.1.7 SFG-UHGL------- image030 image010 The symbol appears as a generic symbol
TANK LIGHT RECOVERY 1.X.3.2.2.1.1.1.1 SFG-EVATW------ image024 image010 The symbol appears as a generic symbol
TANK MEDIUM RECOVERY 1.X.3.2.2.1.1.2.1 SFG-EVATX------ image025 image010 The symbol appears as a generic symbol
TANK HEAVY RECOVERY 1.X.3.2.2.1.1.3.1 SFG-EVATY------ image026 image010 The symbol appears as a generic symbol
SEA SURFACE INSTALLATION, OIL RIG / PLATFORM 1.X.3.4.1 SFG-IRR---H---- image029 image010 The symbol appears as a generic symbol

geomessage All 1.x.3

all

geomessage Error 1.x.3

errori

csmoore commented 9 years ago

I spot checked a few of those IDs and they are missing from the app6b dictionary/style.

Though, oddly, a few have just U/N versions: image

caporossi commented 9 years ago

Assigned support ID: BUG-000088381

csmoore commented 6 years ago

Issues also noted in #291 - looks like except for LANDING SUPPORT and UNIT GENERAL LIAISON all of these symbols are also included in the #291 list (so probably just double check those 2 before closing this as duplicate).

BobBooth commented 6 years ago

MEDEVAC ROTARY WING - replaced symbols with SVGs from 2525C, observed symbols display larger.

BobBooth commented 6 years ago

Updated Keys and Tags for SFGPUCFRS** set - they were incorrectly tagged with duplicates of the SFGPUCFRSS series.

BobBooth commented 6 years ago

Updated Keys and Tags for SUGPUCFMSW- set - they were incorrectly tagged with SUGPUCFMW- (missing the S before the last W).

BobBooth commented 6 years ago

Updated Keys and Tags for SFGPUCRLL-- set. They were incorrectly tagged with SFGPUCRL-- (missing final L).

BobBooth commented 6 years ago

There are a couple of issues with Landing Support: SFG-UUX- According to the APP6-B PDF, the SIC should be SFG-UUL- image

However, this SIC is also duplicated in the standard and represents Law Enforcement Units: LAW ENFORCEMENT UNIT 1.X.3.1.2.3 SGUUL---***** image

Our Landing Support symbol Key is: SFGPUUP--- image Need more information of whether ours should be switched to SFG-UUX- @joebayles - any thoughts? @lfunkhouser - this is another case of duplicate/ambiguous codes in APP6B.

Our Landing Support symbol matches the usage in 2525C image The 2525C standard has S-GPUUL--- meaning Law Enforcement: image

BobBooth commented 6 years ago

SFG-USAW- When I search the style in Pro for Moral, I find a number of symbols with this SIC series: SFGPUSAL-- and with the name prefixed with "Placeholder" Pro symbols tagged with "Placeholder" image

I think we need to import the symbols from 2525C (like sfgpusaw--
image ) and update to remove the Placeholder notation.

BobBooth commented 6 years ago

Updated the whole Moral Welfare series (theater and corps level, in addition to the basic one). Updated symbols from 2525C SVGs, updated tags, updated keys. image SFG-USAW--- SFG-USAWT---
SFG-USAWC--

BobBooth commented 6 years ago

Will wrap these up tomorrow, starting at UNIT GENERAL LIAISON

BobBooth commented 6 years ago

For Unit General Liaison 1.X.3.1.7 SFG*GL---- it appears the ArcGIS Pro style matches the standard PDF. The reason the symbol is not drawing for the user is that the wrong SIC is being requested. User states "SFG-UHGL-------" - has extra UH before the GL, which does not appear in the standard. This one is user error. image

image

BobBooth commented 6 years ago

Update Tank Light Recovery series tags and keys. Standard specifies:

TANK LIGHT RECOVERY | 1.X.3.2.2.1.1.1.1 | SFG-EVATW------ image Pro has SFGPEVATLR key. Changingt to SFGPEVATW image

BobBooth commented 6 years ago

For TANK MEDIUM RECOVERY | 1.X.3.2.2.1.1.2.1 | SFG-EVATX------ Changing Pro tags and Keys from SFGPEVATMR to SFGPEVATX image

BobBooth commented 6 years ago

For TANK HEAVY RECOVERY | 1.X.3.2.2.1.1.3.1 | SFG-EVATY------ Changing Pro tags and Keys from SFGPEVATHR to SFGPEVATY image

BobBooth commented 6 years ago

For SEA SURFACE INSTALLATION, OIL RIG / PLATFORM | 1.X.3.4.1 | SFG-IRR---H---- The standard specifies: image We have a key of: SFGPIRSR-- Not changing our keys. User error, user specified SFG-IRR---H- should be SFG-IRSR---H-

BobBooth commented 6 years ago

Adding symbols to automated test BAT file.

topowright-zz commented 6 years ago

If you need to test this in Pro 2.2 any build after 11391 should work.

BobBooth commented 6 years ago

Ran BAT file. Numerous display errors resulted. Debugged with @csmoore and determined that I had not matched the expected SIC convention in the style. Going back through and fixing.

BobBooth commented 6 years ago

Got key/tags updated. image

Almost all displaying properly now, except for the Moral Welfare series. For some reason, although they preview in Pro with the MWR text on them, it does not appear when exported using the Runtime tool.

BobBooth commented 6 years ago

This shows the Moral Welfare symbols displaying with MWR text in Pro: image

csmoore commented 6 years ago

I can confirm that Pro 2.2 daily does support the current app6b stylx (Tested on ArcGISPro 2.2.11600)

We may need to doc the steps a bit:

  1. Copy app6b.stylx from this repo to
  2. Pro\Resources\Dictionaries\app6b (create folder app6b here if it does not exist)

image

lfunkhouser commented 6 years ago

@dfoll @ACueva @topowright Please read all comments in this issue, understand the issue, and identify the remaining work that needs to be completed.

BobBooth commented 6 years ago

Working on fixing the Moral Welfare symbols. Opened up the SVGs for 2525C and re-centered the (strangely offset) text and frames, saved them out. The fixed symbols look good in the Pro symbol editor, but the font component does not get created in the Runtime symbol export tool. image.png image.png SIDCs/tags look good. Maybe a font installation issue? @csmoore

BobBooth commented 6 years ago

The font is apparently Arial. image.png @csmoore are you aware of any issues with Runtime and the Arial font?

BobBooth commented 6 years ago

Making progress. I was able to open one of the svgs, extract the MWR text, and save it to a svg1.1 file, converting the font to outlines. This new MWR.svg was added as a layer on top of one of the symbols, and the text is now appearing. Must be a font issue. image.png I will save the other copies of the 2525C SVGs for the MWR series symbols with the fonts converted to outlines, re-import them, and I think it will work. @csmoore

BobBooth commented 6 years ago

MWR issues fixed. image.png Converted all of the fonts to outlines, reloaded the symbols.

BobBooth commented 6 years ago

This issue should be complete except for an executive decision on what to do about the two cases where the standard has duplicate SIDCs pointing at different symbols (LANDING SUPPORT and Law Enforcement). @lfunkhouser @topowright @dfoll @ACueva @csmoore

BobBooth commented 6 years ago

We should stick with our current SIC SFGPUUP--- for Landing Support and SFGPUUL--- for Law Enforcement, these match the usage in the 2525C standard, the APP6B stadard PDF seems to be in error).

BobBooth commented 6 years ago

Test script to generate these symbols.

Issue85_problems_all_affiliations.zip

Script output: image

ACueva commented 6 years ago

@BobBooth I spoke with @joebayles RE: https://github.com/Esri/military-features-data/issues/85#issuecomment-372795206 He agrees with your way forward. The likelihood of this APP6B issue being addressed by the symbology committee is low, the way forward is to make sure this has been fixed in APP6D. I will work on verifying this.

ACueva commented 6 years ago

@BobBooth @csmoore I'm reviewing the initial comment. https://github.com/Esri/military-features-data/issues/85#issue-87677204 The SIDC for Rotary Wing Medivac is SFG-IBN---H---- when I search for this item in the APP6B stylx the symbol does not appear. The SIDC that does work for Aviation Rotary Wing Medvac is 2018-03-26_13-31-31 2018-03-26_13-27-22

Just confirming I'm not missing anything.

ACueva commented 6 years ago

APP6B Standard 2018-03-26_13-48-36 ArcGIS Pro 2.2 Build 11859 2018-03-26_13-49-03

APP6B Standard 2018-03-26_14-19-32 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-19-47

APP6B Standard 2018-03-26_14-22-34 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-22-13

APP6B Standard 2018-03-26_14-26-56 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-28-39 Utilizing the same format as 2525C we get the proper symbol. SFGPUUP-------- 2018-03-26_14-30-54

APP6B Standard 2018-03-26_14-32-53 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-33-07

APP6B Standard 2018-03-26_14-34-39 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-35-05

APP6B Standard 2018-03-26_14-36-46 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-37-36

APP6B Standard 2018-03-26_14-40-20 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-43-36

APP6B Standard 2018-03-26_14-45-42 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-46-39

APP6B Standard 2018-03-26_14-48-32 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-48-54

APP6B Standard 2018-03-26_14-49-42 ArcGIS Pro 2.2 Build 11859 2018-03-26_14-50-01

APP6B Standard 2018-03-26_14-58-35

There is no entry SIDC for SEA SURFACE INSTALLATION, OIL RIG /PLATFORM, the closest symbol loads like this: 2018-03-26_14-58-25 Once you modify the symbol and change the SIDC to match the standard, the following loads: 2018-03-26_14-57-55

Verified at Runtime 100.2 2018-03-26_15-09-27

csmoore commented 6 years ago

@ACueva - you are testing the correct symbol/SIDC- it looks like the SIDC entry(SFG-IBN---H----) in the original issue/table was in error (name / image match but not the SIDC)

BobBooth commented 6 years ago

@ACueva - there are a couple of rotary wing MEDEVAC symbols image image

BobBooth commented 6 years ago

That IBN---H is user error. image

ACueva commented 6 years ago

This addresses: https://github.com/Esri/military-features-data/issues/85#issuecomment-376260660 Landing Support in APP6D is mentioned once in the standard. 2018-03-27_8-27-16 It appears the SIDC convention used in APP6B is no longer the same as APP6D. As a result, there is no 1 to 1 comparison possible. FYI @csmoore @BobBooth @lfunkhouser @dfoll @topowright

ACueva commented 6 years ago

Remaining labels are: G-QA Create (Checklist) G-QC Verify (Checklist)
I am not sure they are applicable. Can you please confirm? @lfunkhouser @topowright, Thanks.