search

Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.
Apache License 2.0
39 stars 10 forks source link

Unable to change the entity field for an existing symbol #222

Closed csmoore closed 5 years ago

csmoore commented 6 years ago

As noted in #214 - here

When using 2525D and the Symbol Editor, it does not provide a way to change the symbol type (determined by the entity field) - for example change a symbol from "Infantry" to "Artillery"

Repro Steps:

  1. Select an existing symbol on the map using the select tool on the Modify Tab
  2. Click Next (or Symbol Tab)
  3. You can change the other properties of the symbol, but not the property that changes the symbol entity field/type (this is possible using in 2525B)

Example (2525D) image

Example (2525B) image

csmoore commented 5 years ago

This attribute has been added to the Symbol tab for 2525D:

image

Just let me know if you prefer it to appear first in the list vs. last in the list (or elsewhere). For now, I picked last in list on the basis it would not normally be changed.

csmoore commented 5 years ago

While testing this, I noticed some issues - that I am not sure are related to the changes, but just commenting here in case we see in previous versions:

  1. A deadlock issue when quickly selecting, modifying, and saving edits for a symbol
  2. Symbol selected was not the top-most visible symbol (when multiple symbol in same location), so when you saved edits the symbol did not appear to change
  3. If modifying a line symbol that touched other symbols, this symbol was not re-selected after clicking the Save Edits button (another symbol was selected)

These issues were addressed in commit: https://github.com/Esri/military-symbology/commit/2b5669a7dd1a8f9f43c623b767248bf5725311b0

csmoore commented 5 years ago

Build Solutions\DefenseSolutions\MilitarySymbolEditor\March2019\Dev\54\ created for verification.

dfoll commented 5 years ago

Tested Solutions\DefenseSolutions\MilitarySymbolEditor\March2019\Dev\54\ confirmed fixed. 2525D and APP-6D now can change entity. Confirmed it functionally behaves as well.

image

image

dfoll commented 5 years ago

Doc updated

There were some tab nav issues with MSE, specifically that the Get Started and Workflows tab were not able to navigate to the Resources tab, however Resources could navigate to either of them. This issue was created to track that, and seems to be fixed.

BobBooth commented 5 years ago

Verified doc updates on Dev.