search

Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.
Apache License 2.0
38 stars 11 forks source link

Support 2525C in MSE #332

Closed lfunkhouser closed 5 years ago

lfunkhouser commented 5 years ago

Background

Esri Japan reported that the MSE does not indicate support for 2525C.

Expected Result

The MSE allows the user to select 2525C. The underlying dictionary supporting 2525B Change 2 also supports 2525C.

csmoore commented 5 years ago

There is an existing layer package with the 2525C datamodel at: https://github.com/Esri/military-features-data/tree/dev/military-overlay/mil2525c/lpkx so most of the work should be in the Military Symbol Editor:

  1. Check the 2525 layer package
  2. Adding the 2525C option to the standard selection
  3. Adding a check if the 2525C datamodel already exists in the project - 2525C will have a "Stability | Activities layer (EMS symbols) that 2525B lacks so that is probably how we will have to differentiate
  4. Testing 2525C + checking that nothing breaks with 2525B
BobBooth commented 5 years ago

First pass through the LPKX looks good. Added the 2525C LPKX to Pro 2.3. Layers (and Group Layers) were created for: Air: Air Sea: Sea Subsurface Sea Surface Land: Installations and Infrastructures Land Equipment Units Stability: Activities Control Measures: Control Measures Points Control Measures Lines Control Measures Areas METOC: METOC Points METOC Lines METOC Areas Other: SIGINT Space image.png

Tables were available for each layer, with attributes (seemed like expected attributes). Coded Value Domains were created (Looked correct). image.png

Feature templates were available for one or two feature types, and features could be created from them; symbology looked correct for these: image.png

csmoore commented 5 years ago

You probably just want to check the Activities layer and feature class most closely to verify that the EMS / Appendix G symbols are there as expected (since this was the primary difference from Bc2).

BobBooth commented 5 years ago

Both the 2525D and 2525BC2 LPKXs that I compared this to had more feature templates, and had description text populated for each layer (2525C LPKX did not have description populated for individual layers).

BobBooth commented 5 years ago

I manually added the first 10 points in the 2525C standard for Appendix G by adding a Stability: Activities point and editing the Extended Function Code and Affiliation fields. The symbols displayed as expected. image.png I then added the Appendix G points feature class from the CCompleteTestData.gdb (extracted from the Mil2525-C-CompleteTestData.ppkx in \GitHub\military-features-data\military-symbology-styles\test-data\mil2525c\pro-projects I set the symbology for the layer using the Dictionary renderer and chose the 2525C dictionary option. I used the Full SIDC field to symbolize the layer. The points were symbolized on the map and appear to be good. There was a "Bridge" symbol that was drawing with the inverted question mark with the red X through it. No other points had this or "unknown" symbols. image.png

This Bridge symbol is in Appendix G of the standard on page 1089 (1095 of the PDF): image.png

csmoore commented 5 years ago

@BobBooth - that may be an error in the test data having that G-M-BCB--- symbol as a point, in the Tactical Graphic section it shows it as a line (which is what I would also expect):

image

BobBooth commented 5 years ago

@csmoore - I agree, that is an error in the test data. Should not be a point. We do have line feature "bridge" type in the Control Measure Lines feature class, and they are drawing correctly there.

BobBooth commented 5 years ago

The updated 2525C LPKX is in this (now merged) PR.

csmoore commented 5 years ago

Work on the addin to support this change has started in branch: https://github.com/Esri/military-symbology/tree/csm-332-add-2525C-support

This is taking a little more time than expected - there is an existing startup sequence that (1) tries to determine if the project already has the required schema that matches a standard, and (2) then sets the addin symbol standard to that, that will probably need to be refactored. There are 2 problems with the existing method:

  1. Its scans the project, checks for a GDB that contains every feature class, doing this 4 times on startup will lead to poor performance
  2. The feature class schemas, which were being checked, are identical for 2525C and 2525Bc2, so some other difference will need to be identified for these

I beleive we will need to change this - for now - I was going to change this sequence to look for the featuredataset name that differs, and is unique, with each standard (ex. "militaryoverlay2525d")

dfoll commented 5 years ago

@BobBooth please review

Doc updates

BobBooth commented 5 years ago

@dfoll - reviewed contents on soldev - looks good. Could not access build location to check pdf due to server issue.

BobBooth commented 5 years ago

@dfoll - able to get to server now. Updates present in PDFs.