Trip Wire drawing issue

Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.

Apache License 2.0

39 stars 10 forks source link

Trip Wire drawing issue #352

Open joebayles opened 5 years ago

joebayles commented 5 years ago

Currently, MIL-STD-2525 and APP-6 disagree on how to draw a trip wire (https://github.com/Esri/joint-military-symbology-xml/issues/525).

Regardless, ArcGIS draws it a third way:

The variable line should be the horizontal line on the "t", not the vertical one.

FYI @lfunkhouser

lfunkhouser commented 5 years ago

@joebayles Please update the issue, providing the 2525 and APP6 ways to render as well as the recommended way to implement.

joebayles commented 5 years ago

It's in the link in the description, but here you go:

MIL-STD-2525D

APP-6D

There is a disparity between the draw rules for a trip wire between the two standards. The US Army will investigate which is the proper one, and submit change proposals to one/both standards.

It should also be mentioned that mines in the example are not intended to be a part of the symbol, and are an example. As is the norm with examples vs. templates, it will be removed from the template, and grayed out in the example.

csmoore commented 5 years ago

Since there seems to be an error/disagreement in how this should be displayed, is there a recommendation for one of these in the meantime or is this just on hold until that is decided?

If the issue that we are not following the point ordering then that is because I don't think that has been implemented in Pro yet (#255).

joebayles commented 5 years ago

@csmoore agreed. The committee is going to decide on what it should be, so suggest we hang in the meantime.

The real question is, should we make whatever change we need to make retroactively.

jeconley commented 3 years ago

@joebayles was anything decided about this? With the anchor point drawing that we are currently implementing we have supported for the 2525Bc2/2525Cdrawing with the 3 anchor points.

From 2525Dc1 Anchor Points: This symbol requires two anchor points. Points 1 and 2 define the length and orientation of the straight line (trip wire) portion of the symbol. Size/Shape: Points 1 and 2 determine the length and orientation of the line drawn from the physical mine to the end of the trip wire. The distance between the line connecting points 1 and 2 is the length of the trip wire connected to the mine. Orientation: Orientation is determined by the anchor points.

I am unclear how to supported the 2 anchor point drawing in 2525D. How is the length of the feature determined? Is point 1 supposed to be at the intersection where the two lines cross?

Also, is the line circled in blue part of the trip wire symbol? It wasn't included in Bc2/C. If so how is the length determined?

From Bc2