Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.
Apache License 2.0
39 stars 10 forks source link

Update schema to support text modifiers - Signature Equipment and Country Indicator #353

Closed lfunkhouser closed 5 years ago

lfunkhouser commented 5 years ago

The data model is missing the necessary fields in order for Pro to support these in the dictionary.

There are some text modifiers that can not be mapped in the UI and are missing from the label symbols. These are:

Land: image image

jeconley commented 5 years ago

@lfunkhouser I am going to go ahead and add these new labels to the style and script because we have several changes to install. I am going to add them as "signatureequipment" and "countryindicator" in the script. Please let me know if you want them to be something else. We would need to change them before the end of the release.

csmoore commented 5 years ago

@jeconley - sorry I didn't reply to earlier, the current schema has fields

countrycode (differs from what you have above)

signatureequipment (this matches what you have above)

If you use those we can test with the existing layer packages

jeconley commented 5 years ago

Thanks @csmoore. I will use those names.

csmoore commented 5 years ago

Note: this issue is also related to #363 and from that issue the "Country Indicator (AS)" is to be called "countrylabel"

dfoll commented 5 years ago

work is in PR #382

dfoll commented 5 years ago

New .lpkx creation

dfoll commented 5 years ago

updates to all .lpkx files in #382

dfoll commented 5 years ago

Based upon my best interpretation of the five standards we currently support, with the changes in #385 we support what the standards explicitly state for Signature Equipment and displaying the country name.

For labeling requests that go beyond what is specified by a particular standard, new issues will need to be created

dfoll commented 5 years ago

this was taken care of in #382

dfoll commented 5 years ago

Doc review:

csmoore commented 5 years ago

Verified:

  1. MSE October Resources - bug added to table
  2. MSE homepage - Added to Releases Table
  3. MSE .pdf - bug added to table
  4. Military Tools October Resources - bug added to Issues addressed
  5. Military Tools for ArcGIS Release Notes.pdf - bug added to table
  6. Defense What's new - MSE added to October 2019

Additional Note: switched fixed at version to Pro 2.4 - since it required that version (with DictionaryRenderer changes) to see these labels