search

Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.
Apache License 2.0
39 stars 10 forks source link

MSE Favorites not being saved at Pro 2.4 #374

Closed csmoore closed 5 years ago

csmoore commented 5 years ago

A new problem has surfaced on Pro 2.4 where the favorites are no longer being preserved.

Repro steps:

  1. On Pro 2.4
  2. Launch Pro, Create Project, Launch MSE
  3. Create some favorites
  4. Close Pro
  5. Launch Pro, reopen project
  6. Click on Favorites Tab - Favorites are gone

The source of this problem seems to be changes that were made at Pro 2.4 with regards to the Assembly Cache (C:\Users\{user}\AppData\Local\ESRI\ArcGISPro\AssemblyCache):

  1. The logic for determining if the assembly cache should be recreated from the .Addin file seems to have gotten much more aggressive (any change to the folder seems to trigger a rebuild from cache)
  2. As a result, any files we add or change in the cache folder, seem to be causing the folder to get deleted and recreated when Pro launches
  3. Because several of our addins (MSE, CC, DD) store configuration files (.config) to this cache folder location, these files will no longer be preserved.
  4. Possible corrective actions: a. Contact Core and let them know about this issue: not to delete newer files or .config files b. Move config files to somewhere else (but these files are normally stored with the .dll or .exe so this might break the default .NET behavior)
csmoore commented 5 years ago

Sent email to Core asking if this - any file changes to the Addin cache folder cause the folder to be recreated - is expected behavior. We will likely have to move the config files to a different well-known folder for the 2.4 release (Documents\ArcGIS?).

csmoore commented 5 years ago

Added fix to PR #375 in commit https://github.com/Esri/military-symbology/pull/375/commits/84ed9a014bbe6154f5a26cf4e00dd53539cbc6da - ready for test

dfoll commented 5 years ago

Confirmed that on step 5 of the repro steps favorites exist if you open the previous project you were working in, or a new one. This was an internal change that I do not feel we need to document.