ENH-000124608: Displayed Symbol ID Code can not be copied and Search displays a invalid code that is less than 15 characters. - Githubissues

Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.

Apache License 2.0

38 stars 11 forks source link

ENH-000124608: Displayed Symbol ID Code can not be copied and Search displays a invalid code that is less than 15 characters. #386

Closed cdufault closed 4 years ago

cdufault commented 5 years ago

When creating a new symbol, for a new data item, it would be very helpful to be able to copy the SIDC value generated. This could then be used in a the field in the a feature class that is being edited. When generating a symbol the SIDC values displayed do show the full 15 characters needed to use the renderer in pro. The work flow:

Enter in the search what type of symbol is needed.
Then configure the symbol to look as needed.
The codes displayed in the attached images on the search tab do not have the full symbol id 15 characters.
There is also no where to copy the SIDC code, which is displayed correctly in the symbol tab, from the tool to add to my feature in the data.

Please make all the places the tool displays the codes to be the proper 15 characters. Also please make a place or button to copy the generated 15 character SIDC value.

csmoore commented 5 years ago

Added copy to attribute table and SymbolIdCode attribute to the table in PR #390

Should look/work like this now:

cdufault commented 5 years ago

Got the enhancement number for you. ENH-000124608 in sales force now :)

dfoll commented 4 years ago

@csmoore I have tested this. Only one thing I would like to ask for before merging. I noticed that if you set the Country Code on the Label tab, it does not update the SIDC. For Bc2 this is positions 13/14, I did not do the research to see what the positions are for the other standards. Let me know if you want me to fetch that information for you.

dfoll commented 4 years ago

Copy from the MSE attribute table copies the entire row (as designed)
SIDC is not stored as an attribute in the gdb (known issue #317, waiting to implement this until we design/understand a workflow that does not have a risk of a feature's SIDC and that attributes getting out of sync)

dfoll commented 4 years ago

Doc QC:

[x] Defense Whats new -- after PR 8017 is reviewed and merged
[x] Military Symbol Editor October Resources
[x] \DefenseSolutions\MilitarySymbolEditor\October2019\Dev\147\
[x] Military Tools October Resources
[x] \DefenseSolutions\MilitaryToolsforArcGIS\October2019\Dev\341\

csmoore commented 4 years ago

@dfoll PR #390 updated in commit https://github.com/Esri/military-symbology/pull/390/commits/3e2e212e08fa4ae65004b555e871a89a25195aa1 with fix for country code in SIDC

dfoll commented 4 years ago

@csmoore I have tested the updated #390. I saw issues with the update.

for the standards that use alpha for the SIDC, when you set the country code, the SIDC updates correctly, however, it holds onto that country code as part of the SIDC when you create a new symbol (even though the country code attribute is set to null). This happens even between projects.
~~for the standards that use numeric for the SIDC the SIDC is still not being updated when you set a country code~~ - 2525d/app6d the country code is part of Conditional Set C in positions 21-23 which we do not currently display - with 2525Dc1 this was moved to positions 28-30

csmoore commented 4 years ago

@dfoll PR #390 updated in commit https://github.com/Esri/military-symbology/pull/390/commits/f72b670167d724a6eb7a6072a5994cfa727d83b3 with fix for latest issue (SIDC not reseting country code)

dfoll commented 4 years ago

Tested good with build 149