search

Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.
Apache License 2.0
38 stars 10 forks source link

Unit tests needed #56

Closed ACueva closed 6 years ago

ACueva commented 8 years ago

Build process requires unit tests.

I did try to run existing test, however I got the following error:

c:\test\military-symbol-editor-addin-wpf\source>vstest.console.exe C:\test\military-symbol-editor addin-wpf\source\SymbolEditorUnitTests\bin\Release\SymbolEditorUnitTests.dll
Microsoft (R) Test Execution Command Line Tool Version 12.0.21005.1
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
Passed   CheckLayerForSymbolSetTest
Failed   CoordinateTypeTest
Error Message:
   Test method SymbolEditorUnitTests.SymbolEditorTests.CoordinateTypeTest threw exception:
System.Exception: Host must be a 64 bit executable.  Check target platform.
Stack Trace:
    at ArcGIS.Core.Hosting.Host.Initialize()
   at SymbolEditorUnitTests.SymbolEditorTests.CoordinateTypeTest() in c:\jenkins\military-tools-for-arcgis-build\workspace\military-symbol-editor-addin-wpf\source\SymbolEditorUnitTests\SymbolEditorTests.cs:line 47

Total tests: 2. Passed: 1. Failed: 1. Skipped: 0.
Test Run Failed.
Test execution time: 0.9995 Seconds

c:\test\military-symbol-editor-addin-wpf\source>
csmoore commented 8 years ago

@ACueva - this is ready to verify - the instructions have been updated at link below with how to run this as a x64 process (required by Pro SDK dependencies) - so this command will differ slightly from the other repos (not sure why they would not have Pro dependencies):

https://github.com/Esri/military-symbol-editor-addin-wpf/blob/dev/README.md#developers-1

csmoore commented 7 years ago

OK to close? (Will close if I don't hear back)

lfunkhouser commented 7 years ago

@ACueva please verify

ACueva commented 7 years ago

@csmoore Tests have been implemented. Getting the following Warning:

Warning: No test is available in SymbolEditorUnitTests\bin\Release\SymbolEditorUnitTests.dll. Make sure that installed test discoverers & executors, platform &
framework version settings are appropriate and try again.

I'm updating Visual Studio and trying again.

ACueva commented 7 years ago

@csmoore Looks like it's still broken. Still experiencing the same issue even after updating Visual Studio.

(Added) Using Visual Studio 2013 Update 4

csmoore commented 7 years ago

Based on the number of web reports of similar vstest problems until VS2015 Update 2, we may have to defer this until the build server can be upgraded to a newer version. We have to use vstest to be able to run as x64 (because of Pro dependencies - not sure how the other projects got around these or if they have any).

If no objections, marking this as deferred until build server at VS2015 Update 2 or higher.

lfunkhouser commented 6 years ago

Closing. Unit tests will be written with new functionality and integrated to run automatically.