search

Esri / military-symbology

A user-focused add-in for searching, creating, and editing military symbols in ArcGIS Pro.
Apache License 2.0
39 stars 10 forks source link

Selecting non military features crashes addin (and Pro) #94

Closed csmoore closed 6 years ago

csmoore commented 8 years ago

Selecting a non military feature causes the addin and Pro to crash.

Repro steps:

  1. Open/Enable the Military Symbol Editor addin
  2. Select a feature on the map that is not a military feature (does not have the field "symbolset")
  3. Crash

Solution: this line needs a null check added:

https://github.com/Esri/military-symbol-editor-addin-wpf/blob/dev/source/ProSymbolEditor/ViewModels/MilitarySymbolDockpaneViewModel.cs#L1265

Note: This is a significant bug that will affect anyone using the addin - the addin download should be updated after this is fixed. FYI @Dbarnes1

csmoore commented 8 years ago

Verified by @BobBooth

@Dbarnes1 - it is highly recommended to update the downloads with this fix

Dbarnes1 commented 8 years ago

@csmoore I'll make sure this new version gets in the latest military overlay

csmoore commented 8 years ago

@Dbarnes1 - you may also want to consider patching prior releases

kgonzago commented 6 years ago

Chris McGuire from Defense Services experienced this issue in the latest version of MSE. Re-opening to address/verify issue. Givens: ArcGIS Pro 2.1.1, Military Tools says 2.0 (date created says 6/28/2017 on AddinX file)

csmoore commented 6 years ago

I tried just a simple test and could not repro (non-mil features selected below). So if Chris could either:

  1. Add some more detailed repro steps (and version tested with) or
  2. Try and debug from the latest in this repo

to help us pinpoint.

image

kgonzago commented 6 years ago

Closing this since what the workflow gathered from Chris McGuire is slightly different from this issue.