Military Tools 3.3 Analysis Ribbon GP tools failing to open

[dfoll]

From @BobBooth on February 6, 2019 16:21

The Released versions of Military Tools 3.3 has a problem where the GP tools accessed from the Military Tools button on the Analysis ribbon are all failing to open. They give an error like: "Tool has failed to open ..." with a path to the assembly cache on the system, like C:\Users\myusername\AppData\Local\ESRI\ArcGISPro\AssemblyCache{bea7f059-c69e-4e17-84bd-072236629c0c}\toolboxes

This does not happen with the Dev build 199, which MT3.3 released is based upon. The difference is that in the toolbox folder, all of the files that have spaces in their names have had the spaces replaced by %20 Unicode space code. See: versus the Dev\199 build, which has the spaces intact:

I think this may have happened in the course of copying the tools for signing the add-in, unless there is some difference in the build process between the Dev build and the Release build.

Copied from original issue: ArcGIS/solutions-defense#946

[dfoll]

From @BobBooth on February 6, 2019 16:31

As to why we didn't find it... The Assembly Cache guids are the same. If you uninstall the add-in, the assembly cache is not deleted until you restart Pro. I think if you uninstall and reinstall before restarting Pro, the installation doesn't get replaced.

[dfoll]

From @csmoore on February 6, 2019 17:43

@lfunkhouser This appears to be a signing issue:

Here are the differences between the unsigned and signed version of the addin:

1. Spaces are replaced with "%20" as @BobBooth mentioned above
2. Just as important some of the required folders are being omitted ("scripts", "tooldata" below)

Here is a complete diff report between the signed and unsigned folders:

SignedUnsignedDifReport.txt

Addins to compare:

1. Solutions\DefenseSolutions\ForDar\Pro
2. Solutions\DefenseSolutions\ForDar\BeforeSigning

[dfoll]

From @BobBooth on February 7, 2019 15:20

I have created a branch of military-tools-geoprocessing-toolbox to remove spaces from file names. bb_946_MT_remove_spaces_file_names

[dfoll]

From @csmoore on February 7, 2019 22:11

A build has been created to do the pre-merge testing for this issue:

Solutions\DefenseSolutions\MilitaryToolsforArcGIS\Testing\csm-946-remove-spaces-from-filenames\22\

This build tests these branches/PRs:

https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/406 https://github.com/Esri/military-tools-desktop-addins/pull/98

https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/csm-946-remove-spaces-from-filenames https://github.com/Esri/military-tools-desktop-addins/tree/csm-946-remove-spaces-from-filenames

Also note, the next Jenkins dev build number has been set to 200 (Jenkins.instance.getItemByFullName("MilitaryTools/MT_dev").updateNextBuildNumber(200))

[dfoll]

From @lfunkhouser on February 8, 2019 1:17

Confirmed with the team that spaces are a no-go and they do affect the signed version. Crime Analysis also ran into this issue. Thanks @BobBooth for explaining why it wasn't caught and thanks @csmoore for the quick turn around on the fix.

[dfoll]

From @csmoore on February 8, 2019 19:57

Dev Build 3.3.1.200 at Solutions\DefenseSolutions\MilitaryToolsforArcGIS\March2019\Dev\200\ has been created for testing prior to re-signing

[dfoll]

This was closed in the repo it was moved from. Reason for moving was that we realized we did not think the issue should be living in that repo. Closing.