Military Toolbox as system tools in the add-in

Esri / military-tools-desktop-addins

Military Tools for ArcGIS is a collection of mission-focused enhancements to simplify defense and intelligence workflows in ArcGIS.

Apache License 2.0

26 stars 14 forks source link

Military Toolbox as system tools in the add-in #118

Closed lfunkhouser closed 5 years ago

lfunkhouser commented 5 years ago

Starting at Pro 2.4, Pro allows a system toolbox to be installed with a Pro addin. This eliminates the need to use Conda to install a system toolbox. Crime Analysis is using this method.

Doc Pro 2.2-2.3 users: install toolbox using conda for tools to appear as system tools Pro 2.4+ users: add-in will install tools as system tools

csmoore commented 5 years ago

PR #119 created to test

dfoll commented 5 years ago

@csmoore The tools work correctly from the MT button on the ribbon, as "system tools", and also when you create a connection to the toolbox. I am seeing one issue though. When you install the conda package the Military Tools for ArcGIS tool shows twice and none of the tools (from either toolbox) will open.

Not sure how related it is, but i was getting this warning when i installed the conda package

Repro steps here

dfoll commented 5 years ago

Repro steps

Install Military Tools for ArcGIS add-in (build 331)
Open ArcGIS Pro
Tools appear as system tools and behave
Clone a new Python environment
Make the new environment the active environment
Close Pro
Install the conda package
Open ArcGIS Pro (making sure you are using the environment you just installed MT to)

if you switch back to an environment that has the add-in installed, but not the Conda package, the tools work again

csmoore commented 5 years ago

That is a good catch. We can report this as an issue to Pro (installing a system toolbox both as an addin and conda causes neither to work).

But we may want to decide whether or not we just want to deprecate the Conda package or doc a warning that the conda package is only for use when the Addin is not installed (I don't think Crime Analysis distributes as a conda package now).

dfoll commented 5 years ago

Doc QC

[x] Military Tools Get Started
[x] Military Tools October Resources
[x] \DefenseSolutions\MilitaryToolsforArcGIS\October2019\Dev\337\
[x] Defense Whats new -- after PR 8017 is reviewed and merged

dfoll commented 5 years ago

~~We have decided that we will be removing the Python Package for the October release~~

lfunkhouser commented 5 years ago

Retest on 2.2, 2.3, 2.4

dfoll commented 5 years ago

For the October release we have now decided to leave the Python package in the .zip file. Messaging on the Get started page is good. We will be adding a .readme file to the install warning the user not to install it on 2.4.

lfunkhouser commented 5 years ago

PDF build 341 verified doc updates, PR merged and will wait for next solutions pages build to pick up online changes

lfunkhouser commented 5 years ago

Tested also on Pro 2.5.