Esri / military-tools-desktop-addins

Military Tools for ArcGIS is a collection of mission-focused enhancements to simplify defense and intelligence workflows in ArcGIS.
Apache License 2.0
26 stars 14 forks source link

Coordinate Conversion Adding Redundant Menu to Pro Map Selection Menu #122

Open csmoore opened 4 years ago

csmoore commented 4 years ago

@elinz discovered that the Coordinate Conversion Addin is still adding a pop-up to the map selection menu (nice catch)

This daml code should be removed :

https://github.com/Esri/military-tools-desktop-addins/blob/dev/source/MilitaryToolsForArcGISPro/Config.daml#L355

image

elinz commented 4 years ago

This is also a problem in the config.daml for the coordinate conversion addin also.

@csmoore I was reminded by @troysykes that these tools need to be supported on multiple versions of Pro including the versions where Convert Coordinates wasn't in the core software yet.

csmoore commented 4 years ago

@elinz thanks - I added this to the original issue to make a little clearer.

I think that popup has been included in core Pro since 2.2 (our oldest supported version) so I think we are OK to just remove it

elinz commented 4 years ago

@csmoore Ok. That would be good if that could be just deleted.

FYI. I just tested another way to delete the menu, which I think is what you wanted me to try originally as shown below and this didn't work: image

Nothing that I have tried to either delete the menu or change it's position in the context menu has worked. So hopefully this can just be deleted on your side.

Thanks.