Esri / military-tools-desktop-addins

Military Tools for ArcGIS is a collection of mission-focused enhancements to simplify defense and intelligence workflows in ArcGIS.
Apache License 2.0
26 stars 14 forks source link

Build number captured for Military Tools for ArcGIS similar to CC in ArcGIS Pro #37

Closed topowright-zz closed 6 years ago

topowright-zz commented 6 years ago

Expected Behavior

Military Tools for ArcGIS should have a build number populated based on the build number from Jenkins. This is for ArcGIS Pro only not for ArcMap for now. The code on how we did this for Coordinate Conversion in ArcGIS Pro is the samething we want to do for this issue: https://github.com/Esri/coordinate-conversion-addin-dotnet/commit/22fad093d63e196d51497ed57dc1bf8b44097c98#diff-d9358db34019268f8ca62c22b2ef1c48R222

Current Behavior

Currently we do not have any way to identify what build is installed on ArcGIS Pro

topowright-zz commented 6 years ago

working on making sure that our build process is ready for this capability

topowright-zz commented 6 years ago

Military Tools for ArcGIS is building with build numbers and ready for this feature enhancement when we are able to get to it.

dfoll commented 6 years ago

@topowright where is this build number shown?

topowright-zz commented 6 years ago

Buillt and tested on @kgonzago branch and now we have this: image

The build numbers match the builds for Jenkins. This allows us to start tracking when things worked and what version we are all working with. @kgonzago very good way to end a week of work with this. I am excited!!

topowright-zz commented 6 years ago

It also shows up in this location of ArcGIS Pro as well: image

lfunkhouser commented 6 years ago

We need an internal build number. The version of the add-in is what we release as an official version. Build number and version number need to be different numbers. Can we add a build number to the UI instead?

kgonzago commented 6 years ago

Which UI are you referring to? The UI when installing the add-in or the UI of the Add-in manager in Pro?

topowright-zz commented 6 years ago

Are we one number off based on this capture from ArcMap?

image

topowright-zz commented 6 years ago

@kgonzago is going to make this match the way that we do it for ArcMap.