RegExs from DD Widget applied to all Military Tools add-ins

[lfunkhouser]

From @kgonzago on February 2, 2018 18:28

• [x] Review RegEx used in Coordinate Conversion Distance and Direction Widget
• Reconfigure each notation's regular expression in the add-in to mirror what's in the widget
  • [x] DD
  • [x] DMS
  • [x] DDM
  • [x] GARS
  • [x] MGRS
  • [x] USNG
  • [x] UTM
• Use test json files from the widget in unit tests in add-in
  • [x] DD
  • [x] DMS
  • [x] DDM
  • [x] GARS
  • [x] MGRS
  • [x] USNG
  • [x] UTM

If needed, refactor code to accommodate for new entries added to add-in regular expressions

Copied from original issue: Esri/coordinate-conversion-addin-dotnet#470

[lfunkhouser]

From @topowright on February 5, 2018 15:14

@kgonzago can you give an update on where we are with this task?

[lfunkhouser]

From @kgonzago on February 5, 2018 17:3

@topowright combining regex's now. somewhat tedious process.

[lfunkhouser]

From @kgonzago on February 7, 2018 2:15

The use of regex group names in the add-in is tightly coupled with the the logic of parsing coordinates for each notation. This is the same situation for the widget utilizing indexes instead. Some refactoring is needed with the either JS or C# code if group names are used or removed respectively. I recommend we leave them as is for now and work towards a common .net and JS libraries for regexs.

@topowright @lfunkhouser @dfoll @ACueva Whare are your thoughts?

[lfunkhouser]

From @kgonzago on February 7, 2018 21:20

After talking with @csmoore, the approach going forward is to compile the CC library dll as a nuget package. The CC nuget package will then be uploaded to the MS nuget repository. Any subsequent changes will be reflected in a newly created CC nuget that will be available in the MS nuget repository. Any developer that wants to enhance any of our add-ins will be required to download via nuget the CC dll. Here is infomation on nuget.

[lfunkhouser]

From @topowright on February 7, 2018 21:58

@kgonzago I am interested in understanding in how we will track this work. Are we able to use this issue as the issue to track the workings on getting the library into Nuget? If so does this link identify that process: https://docs.microsoft.com/en-us/nuget/quickstart/create-and-publish-a-package-using-visual-studio

If that is the process to get our library into Nuget do we need to do anything else before moving forward? It sounds pretty clear on what the approach is, but I am confused on the steps that we will have to take in order to finish this effort. We need to document this process in a way to allow our users that need to build our add-ins to understand what they will need. I think all we will have to add in the Nuget folder that is already on our 2.1 build environment.

[lfunkhouser]

From @kgonzago on February 8, 2018 14:41

Yes that link you provided is the process for packaging the CC dll. Here are the high-level steps whenever a change is made to CC:

1. Create nuget package in VS
2. Upload to nuget repository (this can be tied into a build event)
3. Internal and externals devs will need to download the latest package using nuget package manager in VS

As for our build process, we can use the nuget api to download, unzip, and copy the dll in the appropriate directory for our add-ins to reference. Currently, the symbol editor has a directory called dependency that houses this dll. We can follow that same convention with the D&D and Viz add-ins.

[lfunkhouser]

From @kgonzago on February 8, 2018 17:9

After talking with @csmoore, nuget approach would not work in a classified environment. Pivoted to the approach of adding CC as a project reference. This approach is used for Military Tools add-ins.

[lfunkhouser]

From @kgonzago on February 8, 2018 17:10

Add CC project reference to these add-ins:

• [x] MSE
• [x] D&D
• [x] Viz

[lfunkhouser]

From @topowright on February 8, 2018 21:31

Starting to build MSE with Jenkins.

All work for this will be made in this issue: https://github.com/Esri/military-symbol-editor-addin-wpf/issues/211

[lfunkhouser]

From @topowright on February 9, 2018 16:41

We found an issue with the Jenkins build that calls for a change in the CC library which @kgonzago has figured out and is working on. This took some time, but we now are moving forward. This was found when we called MSBUILD on version 14.0

[lfunkhouser]

From @kgonzago on February 12, 2018 17:1

MSE Pro add-in, Viz Pro and ArcMap add-in are complete. Tackling D&D Pro and ArcMap add-in now.

[lfunkhouser]

From @kgonzago on February 13, 2018 0:48

Add-ins (Pro and ArcMap) for MSE, Viz, and D&D have been updated to use the Coordinate Conversion library.

[lfunkhouser]

From @kgonzago on February 13, 2018 0:51

@ACueva @dfoll testing can commence once the build is updated.

[lfunkhouser]

From @kgonzago on February 13, 2018 0:57

FYI @topowright

Update Jenkins Build to pull CC Library for these Add-ins

• [x] Distance and Direction
• [ ] Visibility
• [x] Military Symbol Editor

[lfunkhouser]

From @topowright on February 13, 2018 16:1

Currently finishing up MSE

[lfunkhouser]

From @topowright on February 13, 2018 18:14

Finished working on MSE and moving on to Distance and Direction. @ACueva is working on Visibility.

[lfunkhouser]

From @topowright on February 13, 2018 18:15

@BobBooth @ACueva @dfoll MSE can now be tested from the build location on the server.

[lfunkhouser]

From @topowright on February 13, 2018 18:20

Distance and Direction

• [x] Adding the Solution files to Defense Solutiosn
• [x] Build the solution

1. Create staging
2. Clear staging
3. Copy from repo
4. Copy to stage
   • [x] Create zip file on testing location
   • [x] Build ArcMap
   • [x] Build ArcGIS Pro
   • [x] Prepare the Documentation

[lfunkhouser]

From @topowright on February 13, 2018 19:50

Distance and Direction has been finished and can be tested for Dark Theme and Reg Ex expressions

[lfunkhouser]

Updating title of issue.The DD widget RegExs were used because they were more up to date than CC widget RegExs. JSON files were used from the widget to test The work done was applied to all Military Tools add-ins. Moving this issue to the https://github.com/esri/military-tools-desktop-addins repo.

[lfunkhouser]

Closing. new issue logged to update CC library by @kgonzago