search

Esri / military-tools-desktop-addins

Military Tools for ArcGIS is a collection of mission-focused enhancements to simplify defense and intelligence workflows in ArcGIS.
Apache License 2.0
26 stars 15 forks source link

GP Tools called from the Analysis ribbon not using correct layer file for feature sets #85

Closed dfoll closed 5 years ago

dfoll commented 6 years ago

Logging this here because I am experiencing this using the add-in, but not the toolbox.

Background

Military Tools 3.3 will provide access to our gp tools through a button on the Analysis ribbon. This is in addition to offering the same tools in a Python toolbox and a conda package. This issue is being logged specifically about the behavior from the analysis ribbon.

Current Behavior -vs- expected behavior (add-in -vs- toolbox)

Build 163 of the button on the Analysis ribbon is being compared to the tools in the Python toolbox from build 163. At build 163 this problem seems to be happening with any tool that can use feature sets as inputs. One visual example is given, after that, only the tool name and "symptoms" are given.

Range Rings From Interval

image should only be able to use points as input, also does not have correct symbol like the tool accessed directly from the .pyt

Steps to Reproduce/Additional Info

  1. Open Range Rings from Minimum and Maximum from Analysis ribbon
  2. It opens correctly with correct feature set symbology
  3. Without running anything open Range Rings from Minimum and Maximum from toolbox
  4. It opens correctly with correct feature set symbology
  5. Without running anything open Range Rings from Minimum and Maximum from Analysis ribbon
  6. Tool now opens as described in the issue, without correct symbology.

    Alternative repro steps

  7. Click GRG From Area tool
  8. Tool opens with correct symbology
  9. Click GRG From Point tool
  10. Tool opens with correct symbology
  11. Click GRG From Area tool again
  12. Tool opens without correctly layer file for input feature set

Your Environment

Pro 2.3.0.14508 MT build 163 (built from cybertech-dev branch.

dfoll commented 5 years ago

Fix is in #92 build ...\DefenseSolutions\MilitaryToolsForArcGIS\Testing\cybertech-dev\10 was created to test

csmoore commented 5 years ago

Tested using test build (DefenseSolutions\MilitaryToolsForArcGIS\Testing\cybertech-dev\10) and input and output layer symbology seems to show up correctly for the 2 tools mentioned (GRG from Area and Range Rings from Minimum and Maximum) when run from the Analysis Ribbon.

image

image

csmoore commented 5 years ago

Build created for QA/QC: Solutions\DefenseSolutions\MilitaryToolsForArcGIS\January2019\Dev\181

BobBooth commented 5 years ago

Tested on Pro 2.2. Ran tools using Add-in ribbon, then from Conda package. All had correct input symbology.

dfoll commented 5 years ago

Tested on 2.3 from Commercial\Solutions\DefenseSolutions\MilitaryToolsForArcGIS\January2019\Dev

Tool input symbology is behaving correctly