search

Esri / military-tools-desktop-addins

Military Tools for ArcGIS is a collection of mission-focused enhancements to simplify defense and intelligence workflows in ArcGIS.
Apache License 2.0
26 stars 14 forks source link

Military Tools GP tools run from Analysis toolbar have "pin" symbol for input points #88

Closed BobBooth closed 5 years ago

BobBooth commented 5 years ago

The GP tools installed with the Pro add-in for the Military Tools button on the Analysis toolbar have "pin" symbol for input points. When you add the PYT toolbox to your Pro project and run the tools from there, they have the default blue circle input point symbol. It seems that the tools installed by the Add-In for the Analysis toolbar cannot find the LYRX file for symbolizing the input points.

Expected Behavior

I would expect the symbology of input points from both locations to match.

Current Behavior

These tools Point input feature set symbols are affected: GRG from Point Range Rings from Interval Range Rings from Min Max Range Rings from Min Max Table Linear Line of Sight (Observers, but not Targets) <- it might be useful to know why one works and the other does not Radial Line of Sight Radial Line of Sight and Range

generic blue "pin" symbols when run from Analysis ribbon image

Blue circles when run from PYT: image

Steps to Reproduce (for bugs)

1 .Install the Military Tools Pro Add-in.

  1. Click the Analysis tab.
  2. Click Military Tools.
  3. Choose Linear Line of Sight (or one of the other tools with input point feature sets).
  4. Observe that the input feature set symbols are blue pin markers.
  5. Connect to the \MilitaryToolsforArcGIS\Geoprocessing folder in Pro.
  6. Add a toolbox to your Pro project and navigate to the folder.
  7. Add the Military Tools.pyt
  8. Run the same tool from the PYT.
  9. Notice that the input feature set symbol is a blue circle.

Your Environment

The Conda package was NOT installed at the time. I am still seeing it after having installed the Conda package. image

dfoll commented 5 years ago

@saip @CTLocalGovTeam This is reproducible for me with ArcGIS Pro 15768 and MT 180.

Repro steps

  1. Open Range Rings from Interval tool from the Military Tools button on the Analysis tab
  2. Interactively add a Point for Input Center Features
  3. Run the tool tool will run successfully
  4. Open the Range Rings from Minimum and Maximum tool from the Military Tools button on the Analysis tab.
  5. Use the Create New Features > Points button to add some points to the map note these points are the pushpin style point instead of the blue point

Additional info

  1. Close the Range Rings from Minimum and Maximum window.
  2. Remove the "Range Rings from Minimum and Maximum Input Center Features (Points)" layer from the TOC.
  3. Remove the "Range_Rings_From_Interval_Input_Center_Features_Points" layer from the TOC.
  4. Open the Range Rings from Minimum and Maximum tool from the Military Tools button on the Analysis tab. note that now the symbology for the input layer is correct
dfoll commented 5 years ago

Fix is in #92 build ...\DefenseSolutions\MilitaryToolsForArcGIS\Testing\cybertech-dev\10 was created to test

csmoore commented 5 years ago

This is a repeat of #85 , but these tools input layers appear correctly as well.

image