Military Tools GP tools from Conda package Radial Line of Sight and Linear Line of Sight lack input feature sets

Esri / military-tools-desktop-addins

Military Tools for ArcGIS is a collection of mission-focused enhancements to simplify defense and intelligence workflows in ArcGIS.

Apache License 2.0

26 stars 14 forks source link

Military Tools GP tools from Conda package Radial Line of Sight and Linear Line of Sight lack input feature sets #89

Closed BobBooth closed 5 years ago

BobBooth commented 5 years ago

With the latest build of Military Tools, when I install the GP tools using the Conda install package, two tools in the Visibility toolset lack feature sets for input observer points Radial Line of Sight Linear Line of Sight (input observers missing, targets feature set is present)

RLOS and Range does have feature set.

This was fixed for the toolbox in the repo, I think the Conda package needs to be rebuilt with the latest version of the GP tools.

Expected Behavior

Tools should have input observer points feature sets.

Your Environment

Pro 2.3.0 Beta 2 Military Tools 12/14 build.

lfunkhouser commented 5 years ago

When rebuild conda package, update to version of MT and python in filename militarytools-3.3-py36_0.tar

csmoore commented 5 years ago

Build created to test at: Solutions\DefenseSolutions\MilitaryToolsForArcGIS\January2019\Dev\182

Note: Conda package version has been updated to 3.3 in this build:

BobBooth commented 5 years ago

Tested on Pro 2.2. Used the MT Analysis toolbar tools first, then installed the conda package and tested and the tools from the conda package. Found that the tools all had appropriate input feature sets. It seems to me as though the process of populating the output features box took a long time, and overall performance was generally worse for the tools after the Conda install.

csmoore commented 5 years ago

After numerous travails trying to clone the pro conda environment ("error cloning"), I was able to install the latest dev-built Military Tools conda package and successfully test this tool with latest build on Pro 2.2 and 2.3 - input and output symbology show up for this tool.

Also checked version (3.3 - Note: looks like a Pro bug on Pro 2.1, 2.2 that homepage, description and license do not show up, but they do show up+work on Pro 2.3):

Pro 2.3:

Pro 2.2:

Tested from dev so removing dev and QC labels

lfunkhouser commented 5 years ago

@csmoore The description not showing up was known at 2.2. The team had hoped to push an update to it, but it wasn't critical, so it was planned to show up in 2.3.