search

Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

Majority of Conversion tools fail at Pro 2.2 #263

Closed topowright-zz closed 6 years ago

topowright-zz commented 6 years ago

Tasks to be done 16 May 2018

Verify these work at 2.2 daily build at least as of 16 May 2018

While testing the GP toolbox for ArcGIS Pro 2.2 I found that the conversion tools do not run do to a copied layer that is an intermediate layer that cannot be deleted.

Expected Behavior

Conversion tools should be able to run

Current Behavior

Tools cannot run because they cannot delete a intermediate dataset

Possible Solution

Change writing data to disk to memory

Steps to Reproduce (for bugs)

  1. Open tools list below
  2. Run with sample data

Context

Tools that fail

Your Environment

ArcGIS Pro 2.2

Tool fails due to a error in being able to delete data:

http://pro.arcgis.com/en/pro-app/tool-reference/tool-errors-and-warnings/001001-010000/tool-errors-and-warnings-00576-00600-000600.htm

csmoore commented 6 years ago

I'm seeing this also running the unit tests using today's daily 2.2.12582

But with a slightly different error (that it can't delete the fields):

ERROR 002557: Cannot delete field endX from C:\Users\XXX\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\scratch.gdb\output2PointLines.
csmoore commented 6 years ago

These are the test failures at Pro 2.2 - seems to be only affecting: table_to_2pointline:

Related to #274 

INFO: 2018-05-09 09:56:02,792 ------------ Begin Tests ------------------
INFO: 2018-05-09 09:56:02,823 Platform: Windows-10-10.0.14393-SP0
INFO: 2018-05-09 09:56:02,823 Python Version 3.6.5 |Anaconda, Inc.| (default, Mar 29 2018, 13:32:41) [MSC v.1900 64 bit (AMD64)]
INFO: 2018-05-09 09:56:02,823 Product: ArcGISPro, Version: 2.2, Installed on: 5/9/2018, Build: 12582.
INFO: 2018-05-09 09:56:02,823 -------------------------------------------
...
RESULTS =================================================
Number of tests run: 86
Number succeeded: 80
Number of errors: 5
Number of failures: 1
Number of tests skipped: 0
Percent passing: 93.0
=========================================================

ERROR: 2018-05-09 11:20:14,035 ERRORS ==================================================
ERROR: 2018-05-09 11:20:14,036 test_table_to_twopointline_GARS (conversion_tests.TableToTwoPointLineTestCase.TableToTwoPointLineTestCase)
ERROR: 2018-05-09 11:20:14,037 Traceback (most recent call last):
ERROR: 2018-05-09 11:20:14,038   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\conversion_tests\TableToTwoPointLineTestCase.py", line 125, in test_table_to_twopointline_GARS
ERROR: 2018-05-09 11:20:14,039     "GARS", "GARS_2", None, self.outputLines, "GEODESIC")
ERROR: 2018-05-09 11:20:14,046   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 92, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,048   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 89, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,049   File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\geoprocessing\_base.py", line 496, in <lambda>
ERROR: 2018-05-09 11:20:14,050     return lambda *args: val(*gp_fixargs(args, True))
ERROR: 2018-05-09 11:20:14,051 arcgisscripting.ExecuteError: Start Time: Wednesday, May 9, 2018 10:00:27 AM
ERROR: 2018-05-09 11:20:14,052 Dropping JoinID from output2PointLines...
ERROR: 2018-05-09 11:20:14,053 Dropping startX from output2PointLines...
ERROR: 2018-05-09 11:20:14,054 Dropping startY from output2PointLines...
ERROR: 2018-05-09 11:20:14,055 Dropping endX from output2PointLines...
ERROR: 2018-05-09 11:20:14,062 ERROR 002557: Cannot delete field endX from C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\scratch.gdb\output2PointLines.
ERROR: 2018-05-09 11:20:14,063 Failed to execute (DeleteField).
ERROR: 2018-05-09 11:20:14,064 Failed at Wednesday, May 9, 2018 10:00:28 AM (Elapsed Time: 0.73 seconds)
ERROR: 2018-05-09 11:20:14,065 Failed to execute (TableTo2PointLine).
ERROR: 2018-05-09 11:20:14,066 test_table_to_twopointline_GEOREF (conversion_tests.TableToTwoPointLineTestCase.TableToTwoPointLineTestCase)
ERROR: 2018-05-09 11:20:14,067 Traceback (most recent call last):
ERROR: 2018-05-09 11:20:14,068   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\conversion_tests\TableToTwoPointLineTestCase.py", line 184, in test_table_to_twopointline_GEOREF
ERROR: 2018-05-09 11:20:14,071     "GEOREF", "GEOREF_2", None, self.outputLines, "GEODESIC")
ERROR: 2018-05-09 11:20:14,075   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 92, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,076   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 89, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,076   File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\geoprocessing\_base.py", line 496, in <lambda>
ERROR: 2018-05-09 11:20:14,079     return lambda *args: val(*gp_fixargs(args, True))
ERROR: 2018-05-09 11:20:14,080 arcgisscripting.ExecuteError: Start Time: Wednesday, May 9, 2018 10:01:24 AM
ERROR: 2018-05-09 11:20:14,082 ERROR 000206: Cannot create FeatureClass C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\scratch.gdb\output2PointLines
ERROR: 2018-05-09 11:20:14,089 Failed to execute (XYToLine).
ERROR: 2018-05-09 11:20:14,091 Failed at Wednesday, May 9, 2018 10:01:25 AM (Elapsed Time: 0.87 seconds)
ERROR: 2018-05-09 11:20:14,091 Failed to execute (TableTo2PointLine).
ERROR: 2018-05-09 11:20:14,093 test_table_to_twopointline_MGRS (conversion_tests.TableToTwoPointLineTestCase.TableToTwoPointLineTestCase)
ERROR: 2018-05-09 11:20:14,093 Traceback (most recent call last):
ERROR: 2018-05-09 11:20:14,095   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\conversion_tests\TableToTwoPointLineTestCase.py", line 164, in test_table_to_twopointline_MGRS
ERROR: 2018-05-09 11:20:14,096     "MGRS", "MGRS_2", None, self.outputLines, "GEODESIC")
ERROR: 2018-05-09 11:20:14,101   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 92, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,102   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 89, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,103   File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\geoprocessing\_base.py", line 496, in <lambda>
ERROR: 2018-05-09 11:20:14,104     return lambda *args: val(*gp_fixargs(args, True))
ERROR: 2018-05-09 11:20:14,105 arcgisscripting.ExecuteError: Start Time: Wednesday, May 9, 2018 10:02:20 AM
ERROR: 2018-05-09 11:20:14,106 ERROR 000206: Cannot create FeatureClass C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\scratch.gdb\output2PointLines
ERROR: 2018-05-09 11:20:14,107 Failed to execute (XYToLine).
ERROR: 2018-05-09 11:20:14,108 Failed at Wednesday, May 9, 2018 10:02:21 AM (Elapsed Time: 1.17 seconds)
ERROR: 2018-05-09 11:20:14,113 Failed to execute (TableTo2PointLine).
ERROR: 2018-05-09 11:20:14,119 test_table_to_twopointline_USNG (conversion_tests.TableToTwoPointLineTestCase.TableToTwoPointLineTestCase)
ERROR: 2018-05-09 11:20:14,120 Traceback (most recent call last):
ERROR: 2018-05-09 11:20:14,122   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\conversion_tests\TableToTwoPointLineTestCase.py", line 144, in test_table_to_twopointline_USNG
ERROR: 2018-05-09 11:20:14,123     None, self.outputLines, "GEODESIC")
ERROR: 2018-05-09 11:20:14,124   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 92, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,125   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 89, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,126   File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\geoprocessing\_base.py", line 496, in <lambda>
ERROR: 2018-05-09 11:20:14,132     return lambda *args: val(*gp_fixargs(args, True))
ERROR: 2018-05-09 11:20:14,133 arcgisscripting.ExecuteError: Start Time: Wednesday, May 9, 2018 10:03:13 AM
ERROR: 2018-05-09 11:20:14,134 ERROR 000206: Cannot create FeatureClass C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\scratch.gdb\output2PointLines
ERROR: 2018-05-09 11:20:14,135 Failed to execute (XYToLine).
ERROR: 2018-05-09 11:20:14,136 Failed at Wednesday, May 9, 2018 10:03:14 AM (Elapsed Time: 1.06 seconds)
ERROR: 2018-05-09 11:20:14,137 Failed to execute (TableTo2PointLine).
ERROR: 2018-05-09 11:20:14,139 test_table_to_twopointline_UTM_BANDS (conversion_tests.TableToTwoPointLineTestCase.TableToTwoPointLineTestCase)
ERROR: 2018-05-09 11:20:14,144 Traceback (most recent call last):
ERROR: 2018-05-09 11:20:14,150   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\conversion_tests\TableToTwoPointLineTestCase.py", line 204, in test_table_to_twopointline_UTM_BANDS
ERROR: 2018-05-09 11:20:14,151     "UTM_BANDS", "UTM_2", None, self.outputLines, "GEODESIC")
ERROR: 2018-05-09 11:20:14,152   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 92, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,154   File "C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\toolboxes\Military Tools.pyt", line 89, in TableTo2PointLine
ERROR: 2018-05-09 11:20:14,156   File "C:\Program Files\ArcGIS\Pro\Resources\ArcPy\arcpy\geoprocessing\_base.py", line 496, in <lambda>
ERROR: 2018-05-09 11:20:14,158     return lambda *args: val(*gp_fixargs(args, True))
ERROR: 2018-05-09 11:20:14,158 arcgisscripting.ExecuteError: Start Time: Wednesday, May 9, 2018 10:04:13 AM
ERROR: 2018-05-09 11:20:14,164 ERROR 000206: Cannot create FeatureClass C:\Users\chri0020\Documents\Github\military-tools-geoprocessing-toolbox\utils\test\scratch.gdb\output2PointLines
ERROR: 2018-05-09 11:20:14,165 Failed to execute (XYToLine).
ERROR: 2018-05-09 11:20:14,167 Failed at Wednesday, May 9, 2018 10:04:14 AM (Elapsed Time: 1.09 seconds)
ERROR: 2018-05-09 11:20:14,167 Failed to execute (TableTo2PointLine).
lfunkhouser commented 6 years ago

Removing the V-Pro2.2 label. The version label will be applied when the fix is done and the label added for the version it is fixed in (more than likely the V-Pro 2.1 and V-MT 3.0 labels)

topowright-zz commented 6 years ago

Testing manually on Pro 2.2 daily build I found that the only tool that does not work is the table to ellipse.

Testing on build 12630

topowright-zz commented 6 years ago

@BobBooth is experiencing Table to Ellipsel not working on ArcGIS Pro 2.1 or ArcGIS Pro 2.2

BobBooth commented 6 years ago

Except, now it is working fine for me on ArcMap 10.5 and Pro 2.1... I wonder if this is a GitHub branch sync issue.

topowright-zz commented 6 years ago

All of these tools pass in todays build and previous builds. When using meters as input with our test data the shape area shows up as zero because the area is too small based on the output coordinate system.

topowright-zz commented 6 years ago

This issue does not have anything to do with the unit test. This is a manual test issue.