Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

Pro Addin not accounting for Curvature or Horizon #327

Open AEversole opened 6 years ago

AEversole commented 6 years ago

This Enhancement is for the interface of the addin tools for Pro provided in the download on the following page. http://solutions.arcgis.com/defense/help/military-tools/

Steps to Demonstrate:  Documentation: The following tools do not indicate or document if or how the tool will adjust for the curvature of earth. 

Steps to Reproduce:  1 Open a map with the appropriate elevation surface. 2 Open the Military tools ribbon (install the Solution if not installed)  3 Click visability 4 Using RLOS for example, Set the tool Parameters:

5 Run the tool. 6 The expected horizon should be Apx 5.04 KM based on the listed equation however the map shows visible area past this expected distance. 

Workaround: Apply the workflow from the tool box version of the radial line of sight tool in the Military_Tools_pro toolbox as in testing they do account for Horizon.

BobBooth commented 6 years ago

Line of Sight 3D Analyst core tool has a "use curvature" parameter http://pro.arcgis.com/en/pro-app/tool-reference/3d-analyst/line-of-sight.htm

use_curvature (Optional) Indicates whether the earth's curvature should be taken into consideration for the line-of-sight analysis. For this option to be enabled, the surface needs to have a defined spatial reference in projected coordinates with defined z-units.

CURVATURE —The earth's curvature will be taken into consideration. NO_CURVATURE —The earth's curvature will not be taken into consideration. This is the default.

lfunkhouser commented 6 years ago

@BobBooth @ACueva @topowright @dfoll Our tools use the core tools so we need to identify what is happening or how to enhance if this is not taking into account curvature.

AEversole commented 6 years ago

Hi Lorraine,

I had formally logged a couple enhancements for this, will share the details below.

Action

Record #https://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

Bug Typehttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

Public Statushttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

Synopsishttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

Steps to Reproducehttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

Workaroundhttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

FM Producthttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

FM Versionhttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

Primary Dev Contacthttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

Created Datehttps://esri.my.salesforce.com/_ui/search/ui/UnifiedSearchResults?searchType=2&sen=001&sen=a2q&sen=068&sen=003&sen=a45&sen=a3g&sen=500&sen=005&sen=a8B&sen=a4M&sen=ka&sen=a3q&str=curvature%20military&isdtp=vw&isWsVw=true&nonce=6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd&sfdcIFrameOrigin=https%3A%2F%2Fesri.my.salesforce.com

Edit<javascript:srcUp(%27%2Fa3qf200000056G5%2Fe%3FsrPos%3D0%26srKp%3Da3q%26retURL%3D%252F_ui%252Fsearch%252Fui%252FUnifiedSearchResults%253FsearchType%253D2%2526sen%253D001%2526sen%253Da2q%2526sen%253D068%2526sen%253D003%2526sen%253Da45%2526sen%253Da3g%2526sen%253D500%2526sen%253D005%2526sen%253Da8B%2526sen%253Da4M%2526sen%253Dka%2526sen%253Da3q%2526str%253Dcurvature%252Bmilitary%2526isdtp%253Dvw%2526isWsVw%253Dtrue%2526nonce%253D6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd%2526sfdcIFrameOrigin%253Dhttps%25253A%25252F%25252Fesri.my.salesforce.com%26isdtp%3Dvw%27);>

ENH-000114207<javascript:srcUp(%27%2Fa3qf200000056G5%3FsrPos%3D0%26srKp%3Da3q%26isdtp%3Dvw%27);>

New

For Solutions Military Tools add options to the visibility/ line of sight tools in ArcGIS Pro to adjust for curvature of the earth. (Toolbox tools do adjust for curvature)

ArcGIS Defense Solutions

10.3.1

Matt Funk

5/23/2018

Edit<javascript:srcUp(%27%2Fa3qf200000056xW%2Fe%3FsrPos%3D1%26srKp%3Da3q%26retURL%3D%252F_ui%252Fsearch%252Fui%252FUnifiedSearchResults%253FsearchType%253D2%2526sen%253D001%2526sen%253Da2q%2526sen%253D068%2526sen%253D003%2526sen%253Da45%2526sen%253Da3g%2526sen%253D500%2526sen%253D005%2526sen%253Da8B%2526sen%253Da4M%2526sen%253Dka%2526sen%253Da3q%2526str%253Dcurvature%252Bmilitary%2526isdtp%253Dvw%2526isWsVw%253Dtrue%2526nonce%253D6d8f2c321a2ac81d16ba0fe96431f0071b52309bc10b981d49b9aa415d5114cd%2526sfdcIFrameOrigin%253Dhttps%25253A%25252F%25252Fesri.my.salesforce.com%26isdtp%3Dvw%27);>

ENH-000114364<javascript:srcUp(%27%2Fa3qf200000056xW%3FsrPos%3D1%26srKp%3Da3q%26isdtp%3Dvw%27);>

New

Provide tool in Military tools for ArcGIS Pro that will predict a 3D RLOS or a DEM of minimum elevation visibility based on an observer point.

ArcGIS Defense Solutions

10.3.1

Matt Funk

5/31/2018

From: Lorraine Funkhouser [mailto:notifications@github.com] Sent: Tuesday, June 19, 2018 9:05 AM To: Esri/military-tools-geoprocessing-toolbox military-tools-geoprocessing-toolbox@noreply.github.com Cc: Adam Eversole AEversole@esri.com; Author author@noreply.github.com Subject: Re: [Esri/military-tools-geoprocessing-toolbox] Pro Addin not accounting for Curvature or Horizon (#327)

@BobBoothhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_BobBooth&d=DwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=NJJXg6hFoY4u5_sZQ63_6u4hfqYRSpZ6ImHC6F3bnXM&m=msmgb15g2qT_VE-1Z9zSN0XEeub82YmgiTeFPXDkvlU&s=aF5gl8BGQ7KHM6fsNsswZ0-16F5N_cYVs97oOqmoyG0&e= @ACuevahttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ACueva&d=DwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=NJJXg6hFoY4u5_sZQ63_6u4hfqYRSpZ6ImHC6F3bnXM&m=msmgb15g2qT_VE-1Z9zSN0XEeub82YmgiTeFPXDkvlU&s=icDAOtpzLD_H6CT98VMjR4Z3YPG3K-zsFNu2YJT1r24&e= @topowrighthttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_topowright&d=DwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=NJJXg6hFoY4u5_sZQ63_6u4hfqYRSpZ6ImHC6F3bnXM&m=msmgb15g2qT_VE-1Z9zSN0XEeub82YmgiTeFPXDkvlU&s=ut_zLac92a1h3Q3GdPxwf1POr_i7LRvABMg4WvhKqNQ&e= @dfollhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dfoll&d=DwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=NJJXg6hFoY4u5_sZQ63_6u4hfqYRSpZ6ImHC6F3bnXM&m=msmgb15g2qT_VE-1Z9zSN0XEeub82YmgiTeFPXDkvlU&s=QpShF3tlWtdJZtxhYKLiko690ZEB4egeOsdxQyDxxyY&e= Our tools use the core tools so we need to identify what is happening or how to enhance if this is not taking into account curvature.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Esri_military-2Dtools-2Dgeoprocessing-2Dtoolbox_issues_327-23issuecomment-2D398454169&d=DwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=NJJXg6hFoY4u5_sZQ63_6u4hfqYRSpZ6ImHC6F3bnXM&m=msmgb15g2qT_VE-1Z9zSN0XEeub82YmgiTeFPXDkvlU&s=6OXhxMvsoaBBraLjthV46Wbnp5gXN6Eqvlw1XnluZB4&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Al5cSJdJpg93h-5FbeT2AUfbPHQmLJ0HN2ks5t-2DSEUgaJpZM4URuzs&d=DwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=NJJXg6hFoY4u5_sZQ63_6u4hfqYRSpZ6ImHC6F3bnXM&m=msmgb15g2qT_VE-1Z9zSN0XEeub82YmgiTeFPXDkvlU&s=6lw8bjXmxQEv-Zr7EoCFTdGbzDdluv1SFVseVJ66PT8&e=.