csmoore commented 6 years ago

341 - Add Number Features to GRG Toolset and address labeling on Pro 2.2

Description

341 - Add Number Features to GRG Toolset and address labeling on Pro 2.2

Related Issue

341

Motivation and Context

341

How Has This Been Tested?

Manually (Note: we were requested to not add any more unit tests to repo)

Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.

csmoore commented 6 years ago

@topowright - please see question/comment at: https://github.com/Esri/military-tools-geoprocessing-toolbox/issues/341#issuecomment-397589167

csmoore commented 6 years ago

While trying to repro @topowright 's possible problem I noticed another existing issue with the tool.

The python code assumes the "Features to Number" parameter is a Feature Layer (at the SelectByLayer step) - so if you supply a feature class to the tool it will fail.

UPDATE: it looks like this problem only occurs if there is an existing layer with the same name as the feature class in the Map/TOC. In this case there was a TOC layer called "Structures" so the tool did not create a new layer called "Structures"

topowright-zz commented 6 years ago

This pull request addresses the addition of the tool, but not the labels. I could be missing something, but wanted to add the statement for full clarification.

Esri / military-tools-geoprocessing-toolbox