search

Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

Create Reference System GRG From Area has broken label expression - gives FDO error drawing #359

Closed BobBooth closed 6 years ago

BobBooth commented 6 years ago

The Create Reference System GRG From Area tool from Military Tools build 73 runs and produces correctly symbolized output. However, the labels do not draw and ArcMap (10.3.1 - Advanced) gives FDO drawing error messages.
One or more layers failed to draw:

FDO error: 0 [Failed to label layer output_grid for class Default.] A column was specified that does not exist. A column was specified that does not exist. image

I think the wrong LYR file is being applied. The label expression is looking for [GZD] and that field is not in the output table.

image

Expected Behavior

LYR file applied to output should have correct label expression.

Possible Solution

Find an old version of the LYR file(when it was working) and apply it.

Steps to Reproduce (for bugs)

  1. Run Create Reference System GRG From Area
  2. Digitize a polygon
  3. Accept the default values
  4. Run tool Layer is added, output looks correct, but ArcMap gives FDO error drawing labels. Expression points to a nonexistent field.

Your Environment

Military Tools build 73
ArcMap (10.3.1 - Advanced)

BobBooth commented 6 years ago

@dfoll - testing build 73 of Military Tools on ArcMap, per your request. This and issue 358 (https://github.com/Esri/military-tools-geoprocessing-toolbox/issues/358) are the two problems I found.

@kgonzago - can you compare the LYR file this is applying to the one it used to?

@csmoore - does this pair of issues suggest to you that maybe some old files got stirred into the mix during the midnight build shuffle?

csmoore commented 6 years ago

@BobBooth - I confirmed this is a new bug found and not a configuration management issue

Long answer: since we lost the history with the reorg after PR #355 I did a diff ( - and created a branch: https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/csm/pre-reorg -) against the last commit before the reorgs and the files were the same - except for the one intentional change - adding GetLayerPath function.

Update: There was one minor change - but just opening the GDB in ArcMap could have created such a difference - so probably not significant:

image

BobBooth commented 6 years ago

This one is not yet fixed in kg#358 branch. image @csmoore @kgonzago @dfoll @topowright

BobBooth commented 6 years ago

This was fixed in https://github.com/Esri/military-tools-geoprocessing-toolbox/commit/2bf168f5c37b37e8aaa2ae139a49cfbb9a247264 and appears to be working correctly in the TBX from the repo. Need to retest after conda package is rebuilt.

BobBooth commented 6 years ago

This is fixed in the released version of the PYT available from the current download, for use in ArcMap. image.png.

It is not working correctly in the version installed by the conda package in Pro 2.0.0. image.png

Need to test again in Pro after conda package is rebuilt.

lfunkhouser commented 6 years ago

Adding development label back on since there is work that needs to be done in order to rebuild the conda package.

topowright-zz commented 6 years ago

The layer files that were in the pyt have now been added to the python package. once the PR (https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/372) has been reviewed this issue can be verified.

ACueva commented 6 years ago

Verified in 10.3.1 and 10.6.1: 2018-07-19_13-49-57 2018-07-19_13-55-39