Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

Create GRG from Point - tool works but output not symbolized with LYR file #361

Closed BobBooth closed 6 years ago

BobBooth commented 6 years ago

The Create GRG from Point tool from Military Tools build 73 runs correctly, but the output that is added does not have the correct symbology. image

Expected Behavior

Output should get symbology from correct LYR file.

Current Behavior

Tool runs, GRG polys created and numbered, but no symbology or labeling applied.

Possible Solution

Replace LYR file.

Steps to Reproduce (for bugs)

  1. Create GRG from Point tool
  2. Digitize a point
  3. Accept defaults (I set a rotation of 14 degrees for fun)
  4. Run Result: Tool runs, GRG polys created and numbered, but no symbology or labeling applied.

Context

Output looks wrong

Your Environment

Military Tools build 73 ArcMap (10.3.1 - Advanced)

BobBooth commented 6 years ago

@dfoll - found this other issue while testing Build 73 on ArcMap.

BobBooth commented 6 years ago

Also, when I run this in Pro, I see in the messaging: "... Merging temporary, rotated dataset with output Do not apply symbology it will be done in the next task step Completed script Create GRG From Point... ..."

Isn't this a pre-2.2 version of the code?

@csmoore / @kgonzago does this seem like an older version of the code?

csmoore commented 6 years ago

@BobBooth - I do see that a layer file got dropped in the reorg:

GRG.lyr was here: https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/csm/pre-reorg/toolboxes/layers

But no longer here: https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/dev/Geoprocessing/layers

I'll run a pre and post - diff again since I missed this the last time

csmoore commented 6 years ago

I believe this was caused by the missing GRG.lyr file in the ArcMap set of files/folder here: https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/dev/Geoprocessing/layers

This seems to work now in ArcMap:

image

BobBooth commented 6 years ago

I am attempting to test, but in order to do so, I need a rebuild of the MT conda package. I have started looking at the Utils folder (https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/dev/utils) and am trying to install conda-build on my machine (no luck so far). @topowright - if you can kick off another conda-package build (or point me to instructions on how to do that), I'd appreciate it.

lfunkhouser commented 6 years ago

@BobBooth this issue will be on hold until another conda package is available.

BobBooth commented 6 years ago

I was mistaken about needing a rebuilt conda package. The tool is working correctly in ArcMap 10.3.1 from the current (released) download item. image.png It is also working in Pro (from the conda package installed tool).