search

Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

Number of Radials input set to 0 fails for tools in the Distance and Direction toolset #384

Closed Dbarnes1 closed 5 years ago

Dbarnes1 commented 6 years ago

Expected Behavior

I'd expect to use the Range Rings from Interval, from Minimum and Maximum, and from Minimum and Maximum Table GP tools to create range rings without a Radial.

Current Behavior

Radials are a mandatory parameter across the three script tools, which is fine, but when I set the Radial input to 0, I get an error about a float not being divisible by 0.

Possible Solution

I think the easiest thing to do would be to make the radial input an optional parameter

Steps to Reproduce (for bugs)

  1. Browse to the Distance and Direction Toolset in the Military Tools for ArcGIS Toolbox
  2. Open the Range Rings from Interval, from Maximum and Minimum, or Maximum and Minimum Table tool
  3. Enter inputs, set Number of Radials input to 0
  4. Run the tool

I got this result: image

My hunch is that some invalid math is being applied to the input radial number when it's set to 0

Context

Holistic testing of Military Tools GP Toolbox inside of ICAP.

Your Environment

@dfoll

csmoore commented 5 years ago

Addressed in PR #409

Show behave like this now:

image

dfoll commented 5 years ago

Built to test

dfoll commented 5 years ago

Tested with MT 217

This was never an issue with the add-in

dfoll commented 5 years ago

@BobBooth Doc ready for qc

BobBooth commented 5 years ago

I confirm that this is fixed on Dev and in the build PDF.