search

Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

Table to Ellipse adding _X and _Y field even if you use single field format like MGRS #388

Closed lfunkhouser closed 5 years ago

lfunkhouser commented 6 years ago

From @dfoll: Table to Ellipse is taking whatever coordinate field you give it and adding an "_X" and "_Y" field even if you use a single coordinate style like MGRS. looking back I don't see where this would have been introduced unless it happened here somehow when we were looking at this issue this is happening on Pro2.2 as well

@dfoll Please fill out the issue with the necessary steps to repro with screenshots of the issue. It also isn't clear if this happens on the released September version or just the new build.

lfunkhouser commented 6 years ago

This issue was created based on the comment in the Pro 2.3 MT GP testing issue. Please add any additional information, including steps to repro and screenshots of the issue. Also, it wasn't clear if this happens on the released Sept version of MT.

dfoll commented 5 years ago

When revisiting this I am experiencing slightly different results.

Test Case 1: Use two field coordinates (DD)

  1. Open Table to Ellipse tool
  2. Use TableToEllipse.csv as Input Table
    • Input Coordinate Format DD_2
    • X Field x
    • Y Field y
    • Major Field Major
    • Minor Field Minor
    • Distance Units KILOMETERS
    • Azimuth Field Orient
    • Azimuth Units DEGREES
  3. Run tool runs successfully, output looks correct, attribute table looks correct

Test Case 2: Use single field coordinates (MGRS)

  1. Open Table to Ellipse tool
  2. Use TableToEllipse_single.csv as Input Table
    • Input Coordinate Format MGRS
    • X Field MGRS (note there are several other fields listed that do not show in the file)
    • Major Field Major
    • Minor Field Minor
    • Distance Units KILOMETERS
    • Azimuth Field Orient
    • Azimuth Units DEGREES
  3. Run tool fails, output looks correct, attribute table is incorrect - missing the field that would store the center points

Test Case 3: Use single field coordinates (DD)

  1. Open Table to Ellipse tool
  2. Use TableToEllipse_singleDD.csv as Input Table
    • Input Coordinate Format DD_1
    • X Field DD
    • Major Field Major
    • Minor Field Minor
    • Distance Units KILOMETERS
    • Azimuth Field Orient
    • Azimuth Units DEGREES
  3. Run tool runs successfully, output looks correct, but is in wrong location, attribute table looks correct

TestingTableToEllipse.zip

dfoll commented 5 years ago

Seeing the same behavior with the 2018_10 release

kgonzago commented 5 years ago

Test case 2 was fixed in this PR.

Issue with Test case 3 is Lat/Long was reversed in the CSV file. This caused the Convert Coordinate Notation tool that is used in the tool script to act weirdly. Once the coordinates were in the correct format, Test case 3 worked.

dfoll commented 5 years ago

this looks good testing from the branch, but waiting to move to done because the .pyt is showing as missing when added to arcmap or arcgis pro. @kgonzago @csmoore can we look at this in the morning?

csmoore commented 5 years ago

@dfoll - I believe PR #398 fixed this issue - can you try again testing from dev?

dfoll commented 5 years ago

Built and testing from Commercial\Solutions\DefenseSolutions\MilitaryToolsForArcGIS\January2019\Dev Toolbox opens correctly,