search

Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

LLOS and RLOS tools input observer feature set controls not functioning #391

Closed BobBooth closed 4 years ago

BobBooth commented 6 years ago

Input observer points not working.

Expected Behavior

The tool would allow me to add input points interactively.

Current Behavior

The Input Observers feature set control does not expand and turn to the blue point input symbol when you click the Create Points button to start adding input points for Linear Line of Sight and Radial Line of Sight. On Linear Line of Sight, the Target feature set control works correctly. image In both cases, a layer is added to the TOC for the inputs, but the point feature does not show up on the tool interface. image image

In contrast (and very strangely), the Radial Line of Sight and Range tool works correctly. image

Your Environment

I tested the MT GP tools from the build of the recent reorg (DefenseSolutions\MilitaryToolsForArcGIS\December2018\157. ArcGIS Pro 2.3.0-beta.1+build.14516

Tested from the Conda package version of the tools, then switched my Pro Conda env to default, verified the tools were no longer available in system tools, added a folder connection to the geoprocessing folder, and ran the tools again from the PYT toolbox. Same behavior in both cases. @csmoore tested the toolbox on Pro 2.2 and both tools worked correctly, so seems like this is a Pro 2.3 issue.

lfunkhouser commented 6 years ago

see if layer file used by the tool works in 2.3 compare layer file used by RLOS and Range and RLOS and LLOS

@BobBooth @dfoll will connect on the research

BobBooth commented 6 years ago

PR submitted: https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/392

BobBooth commented 5 years ago

I believe this was resolved for the previous (2.3) release, this issue can be closed. @dfoll @lfunkhouser

csmoore commented 4 years ago

Closing per https://github.com/Esri/military-tools-geoprocessing-toolbox/issues/391#issuecomment-459094960