search

Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

Linear Line of Sight GP tool crashes if an input point is out of the extent of the surface area #401

Closed dfoll closed 5 years ago

dfoll commented 5 years ago

Linear Line of Sight GP tool is causing a crashing if an input is out of the extent of the surface area.

Expected Behavior

Instead of crashing the tool should give an error message in the tool output that at least one point was out of the extent

Steps to Reproduce (for bugs)

  1. Open Linear Line of Sight gp tool
  2. Add an observer
  3. Add a target
  4. Run the tool tool runs successfully
  5. Add another target that is outside the extent of the surface area
  6. Run the tool again Pro crashes

Notes

image Radial Line of Sight shows an error in the tool output

Your Environment

ArcGIS Pro 2.3 MT 189

dfoll commented 5 years ago

@lfunkhouser

csmoore commented 5 years ago

Created PR:2 #402 - To add a check that input points fall within surface before proceeding to RLOS and LLOS.

Output should look like this if points not in extent:

image

BobBooth commented 5 years ago

Rebuilt MT from Dev after merging @csmoore PR and tested the MT RLOS, RLOS and Range, and LLOS from the Analysis ribbon and from the PYT contained in the zip. They are all correctly detecting when observer points (or targets, for LLOS) fall outside of the DEM extent. This issue is resolved.