search

Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

Number Features Tool input feature set difficult to see on Dark Theme, label confusing #405

Closed BobBooth closed 5 years ago

BobBooth commented 5 years ago

The Number Features tool has an input feature set control for designating the area within which to number features. When running ArcGIS Pro in Dark Theme, the grey dotted line does not show up well against the grey background. As a result, when I used it, I made the mistake of thinking the input feature set was unavailable.

I suggest that we update the dashed line input symbology to include grey and white alternating dashes, and to update the string describing the input features to say "Number_Features_Input_Area_Polygon" from the current, more cryptic, "absNumberFeaturesAreaInput". image

This would make it more like the Lowest Points tool. image

csmoore commented 5 years ago

I experimented with this with Bob and any dashed/dark line pattern, even with white added, did not show up well with the GP preview symbol (or on a dark map). We opted to make it like the GRG Area symbol shown below.

Addressed in PR #408 and should look like this now (layer name is also "Input Area" now) :

image

BobBooth commented 5 years ago

Rebuilt MT from Dev, I'm seeing the new symbol in the MT tools on the Analysis toolbar. image Also works correctly from the PYT. Also works in ArcMap 10.3.1.

BobBooth commented 5 years ago

@lfunkhouser - do we need a fixed at Military Tools 3.3.1 tag?