Esri / military-tools-geoprocessing-toolbox

military-tools-geoprocessing-toolbox is a collection of models, scripts, and tools for use in ArcGIS for Desktop and ArcGIS Pro. This toolbox is one component that is a part of Military Tools.
Apache License 2.0
33 stars 14 forks source link

RLOS output should be tied to observer point in some way #50

Open topowright-zz opened 8 years ago

topowright-zz commented 8 years ago

The features created should be able to identify what observer they are a part of

mfunk commented 8 years ago

Should investigate doing Viewshed2 twice, once with the FREQUENCY option and then again with the OBSERVERS option and relate/union/intersect the two. That way we can get both sets of info.

Analysis type (optional)
Choose which type of visibility analysis you wish to perform, either determining how visible each cell
 is to the observers, or identifying for each surface location which observers are visible.

* FREQUENCY—The output records the number of times that each cell location in the input surface
 raster can be seen by the input observation locations (as points or as vertices for polyline observer
 features). This is the default.

* OBSERVERS — The output identifies exactly which observer points are visible from each raster
 surface location. The allowed maximum number of input observers is 32 with this analysis type.
adgiles commented 7 years ago

Addressed in PR #216 please can somebody verify once merged.

This may require documentation changes

NatalieCampos commented 7 years ago

@adgiles I tried this on github on two different machines. The tool fails to execute and gives the error below. Something to do with the video card. I also tried updating my video card driver for each machine, but I still get the error.

image

adgiles commented 7 years ago

Going to revert the changes due to the limitation of the Viewshed2 tool:

Currently, this tool only supports NVIDIA graphics cards with CUDA compute capability 2.0 or OpenCL 1.2 and is dependent on your system having an appropriate card installed. To ensure proper tool execution, see the NVIDIA driver update pageNVIDIA driver downloads for the latest available driver.

adgiles commented 7 years ago

@NatalieCampos can you verify the tool is back to how it was originally working

NatalieCampos commented 7 years ago

Tool seems back to original working condition. This issue/enhancement will not be closed but assignments will be removed.

topowright-zz commented 6 years ago

The creation of this issue really does not explain what was needed. Running this in ArcMap it does not create an output for observer point, but out of the box the gp tool does this for ArcGIS Pro. I feel like if we added and output for observer point that would be the first step to understanding what observer is tied to what RLOS; however, that would only be done visually. Does anyone think we should be saving each RLOS as its on feature class? @dfoll @ACueva