search

Esri / nearby-javascript

ArcGIS API for JavaScript app to find places nearby and route to the nearest location.
Apache License 2.0
41 stars 24 forks source link

Search button timeout is very short #19

Closed andygup closed 5 years ago

andygup commented 5 years ago

I'm not sure about the use case(s) for having a short timeout. I suggest bumping the Notification.tsx snackbar timeout from 3000 to something like 10000, or longer.

odoe commented 5 years ago

That was the default of the component. The spec has the range between 4-10 seconds. https://material.io/design/components/snackbars.html#behavior

I can bump it up to 10 seconds, I just didn't want it to hang out too long.

andygup commented 5 years ago

Yep, it's a little bit like whack-a-mole for me when set to 3s.

On a related note, when I was in the map page, on a mobile device, it wasn't clear what clicking the search button was doing? Search seems like it should be in the header bar so that you always have the ability to search?

odoe commented 5 years ago

I don't know if there is enough header space for another button on a mobile device without being too cluttered. I can work on some ideas though.

odoe commented 5 years ago

fixed in https://github.com/Esri/nearby-javascript/commit/02f76cdc1ca86e5217591be9ccf394f2dd762f61

andygup commented 5 years ago

LGTM, much better.