Esri / nearby-javascript

ArcGIS API for JavaScript app to find places nearby and route to the nearest location.
Apache License 2.0
41 stars 24 forks source link

Not sure how filter is supposed to work? #23

Closed andygup closed 5 years ago

andygup commented 5 years ago

How is the filter supposed to work? It seems like it reorders the list somewhat inconsistently. Is it supposed to only display results based on that keyword?

Here's an example where I selected filter by "Pizza"

image

And, the same list when filtered by "Hotel"

image

This is filtered by "Coffee Shops", the hotel is still at the top of the list:

image

odoe commented 5 years ago

There is some discussion on this in #8.

You can look under the Supported category values on this page.

Food is a category 2 value. Pizza is a category 3 value.

All Pizza is a Food, but not all Food is a Pizza, if that makes sense.

When the category filters are updated, the request is sent back to the geocoding REST API and the results are shown as given. I don't resort or change them in any way.

andygup commented 5 years ago

@odoe Thanks, yep I get the sub-categories. My expectation is there should only be a single, top-level category requested when applying the filter. The app is generating multiple categories per filter-based request. That seems like a bug?

Reference: https://developers.arcgis.com/rest/geocode/api-reference/geocoding-category-filtering.htm => Category Request Details.

Example 1: When I select "Hotel", here's what I'm seeing in the findAddressCandidates request header:

category: Coffee Shop,Hotel
// My expectation => category: Hotel

Example findAddressCandidates request with a single category

Example 2, when I select "Pizza":

category: Coffee Shop,Pizza,Hotel
// My expectation => category: Pizza

Example 3, and when I select "Food":

category: Coffee Shop,Food,Pizza,Hotel
// My expectation => category: Food
andygup commented 5 years ago

OHHHH, you have to de-select filters! That wasn't intuitive.

mikewilburn commented 5 years ago

@andygup this was my first thought when I saw this issue pop up. Glad we don't have any bugs here! Yes, you must de-select the category filters to update the POIs shown on the map & in the list. By default, they're all enabled.

odoe commented 5 years ago

I think we're ok on this one @andygup