Esri / react-arcgis

A few components to help you get started using the ArcGIS API for JavaScript and esri-loader with React
Apache License 2.0
319 stars 79 forks source link

wanted: additional project maintainers/contributors (all experience levels welcome) #79

Closed jgravois closed 4 years ago

jgravois commented 5 years ago

even if you don't consider yourself an experienced React or ArcGIS API for JavaScript developer, this popular project is a great opportunity to get your hands as dirty as you want with some tech that continues to grow in popularity and help other developers 💻.

if you're willing, even sporadically, to review issues, help with documentation or chip in with an enhancement request or bug fix, please click the Watch button and jump on in 🏊‍♀️!

the repository is a friendly place and i guarantee you'll learn something in the process 📚.

cc/ @NoashX, @odoe, ??

tomwayson commented 5 years ago

I'm in.

jgravois commented 5 years ago

@tomwayson thank goodness. i don't know anything about React! 😹

abdel-abdelrazek commented 5 years ago

I'm in please.

nicksenger commented 5 years ago

:wave: @tomwayson

Great to have you and @abdel-abdelrazek here. I've been MIA the past couple months but will try to be more active here if things come up.

travisbutcher commented 5 years ago

I am willing to start working on some pieces of this, just getting my feet into the React and Typescript pools.

tomwayson commented 5 years ago

This is the only repo I've ever seen where there are more maintainers than open issues, and in fact, the only open issue is to solicit for more maintainers. 🤔 Could be a business model in there...

agustin-pt commented 5 years ago

I'd like to join!!

tomrussell commented 5 years ago

Are there any plans to offer React components for other modules in the JS API? Perhaps without the need to use the dojo module loading mechanism? We're building map apps that need deploying offline, with minimal external dependencies

I'd be happy to help contribute if there was interest in taking this on

tomwayson commented 5 years ago

Are there any plans to offer React components for other modules in the JS API?

No, but feel free to propose modules you'd like to see in issues.

Perhaps without the need to use the dojo module loading mechanism?

How would you do that?

We're building map apps that need deploying offline, with minimal external dependencies

You can already use this library and the underlying esri-loader "offline", at least to the extent that you can use the ArcGIS API w/ JavaScript "offline" at all (i.e. you have a local server for not only the modules, but the data, and the assets). Do you have a specific scenario that is not addressed already?

tomwayson commented 5 years ago

Let me expand on:

No, but feel free to propose modules you'd like to see in issues.

I think the primary value of this library is that it gets people up and running fast w/ commonly used components. Once you are up and running with those, you're probably better off writing one-off, purpose-built components that are specific to your application's needs. It is much harder to design a generic component that is useful in many different applications.

I'd say we're aiming for the 90/10 rule here. The 10% of the ArcGIS API that is useful to 90% of the users trying to get it into their React app. Maybe 95/5.

So if there is a component that would be useful to 90-95% of the people trying to get the ArcGIS API into their React application that is missing from this library, we want to hear about it, otherwise I think we're better off investing our time in ensuring that there's good documentation for how to create your own React component w/ esri-loader.

tomrussell commented 5 years ago

Hey @tomwayson, what I was hoping to find with this library was the ability to work with the components of the JS API without being tightly coupled to the ArcGIS Portal. The majority of our deployments include an ArcGIS installation, but some have an existing GIS platform that we would need to integrate with our products, having consistency and no external dependencies in our UI code could really help us streamline this.

I have seen the esri-loader has the ability to load modules from a self-hosted web server, but this being a React library I was wondering if React's own lazy loading and code-splitting features could be used for the same purpose as Dojo. I haven't done much of a deep-dive into the underpinnings of the JS API, so what I have in mind may not even be technically feasible, but it'd be great to have our React bundle completely self-contained.

Interested to hear your thoughts on this.

tomwayson commented 5 years ago

The only way to have a completely self-contained React bundle is to use https://github.com/Esri/arcgis-webpack-plugin

If you use that, you will have to create your own components, or port the ones in this repo (if they suit your needs).

Just to clarify on:

to work with the components of the JS API without being tightly coupled to the ArcGIS Portal.

ArcGIS Portal is not required at all for esri-loader. It only requires the URL to a built version of the ArcGIS API for JavaScript.

jgravois commented 4 years ago

y'all definitely appear to have things under control here.