search

Esri / solution.js

TypeScript wrappers running in Node.js and modern browsers for transferring ArcGIS Online items from one organization to another.
https://esri.github.io/solution.js/
Apache License 2.0
39 stars 12 forks source link

disableDiscussions setting is not being set when deploying Hub sites #1050

Closed chris-fox closed 1 year ago

chris-fox commented 1 year ago

Not sure if this requires a change in Hub.js. in the template json we are adding "disableDiscussions" to values.capabilities:

"capabilities": [
            "api_explorer",
            "pages",
            "my_data",
            "social_logins",
            "json_chart_card",
            "document_iframes",
            "items_view",
            "app_page",
            "underlinedLinks",
            "globalNav",
            "socialSharing",
            "disableDiscussions"
        ]

This exists in the template solution item, but when deploying this value is removed from the payload to addItem when creating the site. We would like to persist this setting when deploying the site. You can reproduce this issue with the solution item:

e3d4166191d84513bfe796bcc0ac3280

The template 'Quality Roads' has this setting, but when deployed it is stripped.

MikeTschudi commented 1 year ago

@chris-fox, this setting is in hub.js. PR https://github.com/Esri/hub.js/pull/1003

MikeTschudi commented 1 year ago

Available via hub.js update in #1087

MikeTschudi commented 1 year ago

Branch https://github.com/esri/solution.js/tree/ch/1050-disableDiscussions adds deploySolution demo for testing this fix.

shoe913 commented 1 year ago

Verified