Esri / solutions-components

A collection of UI components for constructing webapps.
Apache License 2.0
15 stars 7 forks source link

Support Floor Filtering in new Reporter and Manager apps #130

Closed jmhauck closed 8 months ago

jmhauck commented 1 year ago

See: https://devtopia.esri.com/WebGIS/solutions-web-development/issues/22

avezina commented 1 year ago

We need to discuss implementation and impact areas.

azizaparveen commented 1 year ago

Test map: https://localdeployment.maps.arcgis.com/apps/mapviewer/index.html?webmap=b422923b7a4c4958b9788118255f2f0a

jmhauck commented 1 year ago

@avezina this has been in for awhile and ready for review

azizaparveen commented 1 year ago

Test devext map for this issue https://solutions.mapsdevext.arcgis.com/apps/mapviewer/index.html?webmap=89c348ba385948ee905f88b95d7517e2

avezina commented 1 year ago

Looking into, what's the expectation here? The web map loads, but there isn't a way to filter the different floors. I assume the FloorFilter widget should show up as one of the map tools? https://developers.arcgis.com/javascript/latest/sample-code/widgets-floorfilter/ image

azizaparveen commented 1 year ago

@avezina I need to make the map floor aware, forgot to do that, let me find the settings for that, and will reach out

avezina commented 1 year ago

OK resolved the web map issue, the widget icon is showing up https://solutionsdev.mapsdevext.arcgis.com/apps/instant/manager/index.html?appid=3c0bc1c820d149fcb8813103380c18cb image But the widget is not loading properly image

azizaparveen commented 1 year ago

As per our discussion,

azizaparveen commented 11 months ago

Discuss with Indoor team about this what is the expectation whether to have config option, AP will reach out

avezina commented 11 months ago

This is what ExB is going to implement in the next release: a checkbox option to allow filtering of the data source by floor. image

azizaparveen commented 11 months ago

Instant App is practicing the same behavior in 3D viewer. image

azizaparveen commented 8 months ago

looks good in devext. Test app:https://holistic.mapsdevext.arcgis.com/apps/instant/manager/index.html?appid=3f7e39f0545a49bf9cc07055520fcdfb

chris-fox commented 8 months ago

@azizaparveen, I am noticing some issues in the UI of the floor filter widget. When displayed there is a empty white space on the right side of the buttons that I don't see in the map viewer:

image

When expanded the white space is even worse:

image

azizaparveen commented 8 months ago

@jmhauck I can't seem to open the floor filter widget this morning manager_floorfilter test app: https://holistic.mapsdevext.arcgis.com/apps/instant/manager/index.html?appid=3f7e39f0545a49bf9cc07055520fcdfb

azizaparveen commented 8 months ago

The issues are not reproducible in devext anymore. image

azizaparveen commented 8 months ago

I am seeing the following issue again in qa, and I am seeing this behavior in Chrome FYI, @sarahmcdonald7 Test app: https://solutionsqa.mapsqa.arcgis.com/apps/instant/manager/index.html?appid=38a8886d4c214220b42514d25fe61abb

azizaparveen commented 8 months ago

I see these issues both in dev and qa

jmhauck commented 8 months ago

@azizaparveen seems to be working this morning...I don't really know what to do to increase stability of this. I've not changed anything about it since first adding it but seems like it comes and goes. It's wrapped just like the other JS api widgets we show on the screen so it's weird that it just stops every so often and the others don't seem to do the same.

image

azizaparveen commented 8 months ago

Thanks John, closing this.