Closed avezina closed 11 months ago
I think a no map option is useful, in the scenario where i am editing standalone tables (i.e no layers). This was a request we received in the past that we never implemented, but we have had solutions that we have wanted to support editing a table only that we were unable to use manager for.
In terms of the table on top details on bottom layout in the old manager, I believe we are just replacing that default layout with the table on the right and and details and map on the left stacked on top. I like your suggestion of being able to expand or collapse the map in that layout.
@chris-fox In terms of configuration, I believe Instant Apps currently always requests to select a map item at the start? Will we allow to choose a feature layer item only? If a map is always requested when configuring the app, would there be a benefit to still allow the app author to choose if they want to show or hide the map in all the different layouts, rather than enforce layouts with and without map?
I think we can still require a map as the item to start with, users can add standalone tables to a web map and configure the pop-up and edit form from the map viewer.
I do think it would be a good config option to allow users to hide the map in all layouts. We have use cases where we don't need a map in the editing experience.
@chris-fox @avezina Nearby IA template have Hide map configuration settings in Theme and Layout option, I will request Sarah to add that if it doesn't come by default with Theme and Layout option.
@azizaparveen Do you think we should revisit the Layout options with Sarah as well? It seems in this case we may only have 2 layout options: Vertical and Horizontal (no more Grid option), with the ability to show or hide the map in both cases?
Another question to both of you, if we can expand and collapse map or hide map. in the first layout, it turns to vertical layout, so do we need to provide the option for vertical layout? I think we can get away with two options
@avezina Sorry, I just thinking the same, lol. Yes, I will reach out to Sarah about this
Vertical and Horizontal (no more Grid option), with the ability to show or hide the map in both cases?
I was kind of leaning towards grid and horizontal layout, I think, hide map option should be off by default, so by default it will be grid layout
@azizaparveen here's what I visualized (These layouts could have any name that makes sense - open for discussion 😄)
Side by side with map The below is pretty much what we already have, but I thought we could add the option to expand/collapse the map and info panels vertically (see https://github.com/Esri/solutions-components/issues/266). In this way, the user could also expand the popup or Editor full height, or expand the map full height.
Side by side without map
Stacked with map Map and info panel positions could be interchanged left/right below.
Stacked without map I've some concerns with the display below for the Editor widget. We'd want to see what that looks like. It might be fine in Mobile, but I'm not sure what will be the best way to handle the Mobile layout moving forward. Not sure if Mobile should just automatically adapt to the screen width rather than let the user pick a layout for it. Sarah and Lucy may have some ideas and recommendations here.
Another question is: should we just have a configuration option to pick a layout? Does it still make sense to provide a run time layout switcher?
Also see https://github.com/Esri/solutions-components/issues/267, wondering if we can save some space in the UI by eliminating some white space.
@avezina, here are my thoughts
Side by side with map and without map screenshots are looking good, collapse and expand capability will definitely add value. this is the current default layout, I propose to call it grid layout
Stacked with map: what do you mean by "Map and info panel positions could be interchanged left/right below"? did you mean we can interchange at runtime? In 3.x version, map is in the right, may be we should stick to the 3.x version layout and have the info panel at left, and Map on right. I propose the name for this is Classic grid layout and make this default option.
Stacked without map: Lets talk about this with Sarah and Lucy as you suggested but I am not too concerned since users have option to use other layout if it does not work for them.
Runtime layout switcher gives flexibility to the users to pick a layout what works best for them, in many cases the person who configure the app are not the same one as the user, so it helps in that sense, also dont not feel strongly about this, if you and Chris decide to have it in the configuration, I will go with that.
what do you mean by "Map and info panel positions could be interchanged left/right below"? did you mean we can interchange at runtime?
Sorry, I meant that in my draft I display the map on the left. But it could be placed on the right instead, as we had in CM 3x.
- Runtime layout switcher
I don't have the full insight on this requirement myself, but if needed we should review our user workflows and use cases and see what makes the most sense.
Answering the above questions may help answer these:
@avezina, i like your designs and the ability in all modes to support expand/collapse between each of the different sections. Also agree for parity I would include the details on the left and map on the right in the horizontal orientation.
w/ regards to the runtime layout switcher, I also had questions about the need for this. For example is this something that would be persisted between sessions in the browser cookies? It would be annoying if I had to click every time I needed to open the app.
I lean towards making this a configuration option. The other benefit for doing this is right now the runtime layout switcher is in the app header, this would force the app header to be displayed. I would prefer if the app header was configurable like other instant apps because we have sometimes where we don't want a header because we are embedding it in another app like ExB.
I would prefer if the app header was configurable like other instant apps because we have sometimes where we don't want a header because we are embedding it in another app like ExB.
@chris-fox we can request this to IA apps team for this particular app, may be in full release version.
@chris-fox @avezina @jmhauck This is what I envision layout option in the configuration, it will be in Theme and Layout -> Layout tab, I think it will be helpful if the icons change when hide map toggle is on to show how the arrangement will look like. Please let me know your thoughts. the names (Classic grid and grid) I used here are just suggestion, please let me know if you have any other idea.
@avezina @chris-fox @azizaparveen A lot of details in here...will need to read through more but general question. When the map is hidden will the user still be able to choose from a list of maps?
@jmhauck Here's a summary of what was decided here:
- When the map is hidden will the user still be able to choose from a list of maps?
Yes I think we still need to be able to choose which map and layer we are working with... @azizaparveen any further thoughts?
@jmhauck I agree with Alix, I think we will need this, since we support multiple maps and it drives the layer list switcher. Will they look something like this?
@azizaparveen, @avezina This came up in conversations with Dan and Brandi on their solution that will just be table editing. In their use case they have a table related to another table and want to use manager to edit the primary table and the related table. There are no other editable layers in the map.
They would like to not display the map as there will be nothing in the map other than a basemap and is not helpful to the workflow.
It got me thinking do we need a config option for this or should we just hide the map if there are no editable layers in the webmap? I don't recall use cases for hiding the map if there are editable layers, but it seems like I would never want to show the map if I am only working with tables in the app.
should we just hide the map if there are no editable feature layers in the web map
That would make sense to me.
Agree with you @chris-fox, if we go to this route,
Should it be defaulted to two vertical columns
Do we need to give users any change layout option at all (config)? I feel like we don't need it. Did you hear any request for additional layout?
I also feel like we don't need a config option, it seems intuitive to me to show a map when working with layers and to not when only working with tables.
I agree that the layout would be just two vertical columns. I would keep the same width ratio as it is today when You just expand the information section up to cover up the map.
@azizaparveen, if we agree that this should just be the default behavior for table only editing and no config option is needed do you think we could try to add this for R1? This would help a solution being worked on by Dan and Brandi and it would help support our Table editing story w/ #428.
@jmhauck Here is the summary of what we decided and we would like to see if this can be done in R1.
Looks good to me in devext
Not sure what the plan is for showing or hiding the map in the different layouts, but I was wondering if there may still be value in having a map for this layout?
The similar layout had a map in 3.x
Not sure if showing/hiding a map in the layout could be a configuration option for the IA template?
@chris-fox @azizaparveen