Esri / solutions-components

A collection of UI components for constructing webapps.
Apache License 2.0
10 stars 4 forks source link

Text appears in the top when commenting #674

Closed skrishn closed 3 weeks ago

skrishn commented 4 weeks ago

In this app, comments is configured as the title, and it has multiline text, and when entering a value in the comments, the same text shows up in the top. In this app, I still see it when changing it to single-line text. I'm noticing this after this fix https://github.com/Esri/solutions-components/issues/654.

https://localgovdev.mapsdevext.arcgis.com/apps/instant/reporter/index.html?appid=39657e1adb434f9086823b993c70057f

image

Also, I'm not able to repro it in this app - https://localgovdev.mapsdevext.arcgis.com/apps/instant/reporter/index.html?appid=22861dc390674183a89f7ddd4edfd974

chris-fox commented 4 weeks ago

@skrishn, I believe you can configure that in the form, you can specify a field as the title of the form

sumitzarkar commented 3 weeks ago

@skrishn

This is expected because the formInfo has Comments as the title of the form

image image

skrishn commented 3 weeks ago

@sumitzarkar I find it distracting when submitting a comment. Can we avoid this behavior?

chris-fox commented 3 weeks ago

I don't think we should change the behavior, users can configure the title of the form to whatever they want. They can remove it as well if they don't want a title.

skrishn commented 3 weeks ago

I agree with Fox, but the behavior of the text appearing as you type in the field isn't the best user experience and we should change it.

comments

chris-fox commented 3 weeks ago

its the same in the map viewer, this is just coming from the edit widget. I don't think we should override the behavior.