Esri / solutions-components

A collection of UI components for constructing webapps.
Apache License 2.0
10 stars 4 forks source link

Allow blank report panel header #690

Open HeatherEisan opened 2 weeks ago

HeatherEisan commented 2 weeks ago

Describe the bug

When the Report panel header text box is blank the word Reporter appears in the panel.

Expected Behavior

When the text box is blank I would expect no text appears in the panel.

Reproduction Steps & Sample

  1. Go to this URL - https://localdeployment.maps.arcgis.com/apps/configure-template/index.html?appid=b34f0d437b1142fab995176220e21462
  2. Click the Reporter tab.
  3. Click Panel Options.
  4. The Report panel header is blank, but the panel header has the word Reporter on it.

Other Relevant Info

No response

skrishn commented 2 weeks ago

@HeatherEisan It uses the fallback text when the field value is left blank. Is there a reason behind allowing it to be blank?

HeatherEisan commented 2 weeks ago

I don't think it should be required to have a panel header. Might not be the best comparison, but panel headers are optional in ArcGIS Dashboards, Experience Builder, Countdown Instant App. It a little unusual that the text displayed in the panel header, isn't visible in the text box.

chris-fox commented 2 weeks ago

@HeatherEisan, one thing to note is in the R2 release if you only have one layer configured in the app the app will automatically load to display the list of features for the layer, so the 'Reports' header won't display anymore, it will just display the layer name that you have configured in the web map.

image

HeatherEisan commented 2 weeks ago

@chris-fox: So there will not be an option to have no header, unless the layer name is blank?

chris-fox commented 2 weeks ago

There is not at this time, I have not tested what will happen if you make the layer name blank. We are also using the panel to display the back button, filter and sort buttons. So even with this enhancement we would have to consider where we place these items if the header was blank or if we just have a blank panel.

In your scenario I would just name the layer 'Land Use Cases', this seems pretty intuitive to me as a header for the items listed.