search

Esri / solutions-components

A collection of UI components for constructing webapps.
Apache License 2.0
10 stars 4 forks source link

loading and rounding #707

Closed jmhauck closed 1 week ago

jmhauck commented 1 week ago

@MikeTschudi good call...I can't actually say at this point if it stalls there...but makes sense that it could. We can certainly still continue working with the app but the functions its supposed to call on table load don't occur. I'll go ahead and move it before just in case.

jmhauck commented 1 week ago

@MikeTschudi seems like its failing on npm run build in codeql-analysis.yml. I see some suggesting something like CI=false npm run build any ideas on how we should address?

MikeTschudi commented 1 week ago

The build errors have been really strange. I restarted the PR's Travis a couple of times without luck. I'm trying the other PRs after boosting Travis to use Node 18 (for Stencil and Puppeteer) and a later Ubuntu (for Node 18). Got them all to pass; now merged in this PR to see if that works.

MikeTschudi commented 1 week ago

Looks good; let's merge this via PR #708

jmhauck commented 1 week ago

Thanks @MikeTschudi

jmhauck commented 1 week ago

645