Esri / solutions-components

A collection of UI components for constructing webapps.
Apache License 2.0
11 stars 5 forks source link

Remove/hide reset filter from the filte modal #868

Open skrishn opened 1 week ago

skrishn commented 1 week ago

Related to this enhancement https://github.com/Esri/solutions-components/issues/647

Having two reset filters look redundant and let's hide/remove the first one as highlighted.

image

sumitzarkar commented 1 week ago

@jmhauck

To implement this we need updates in the instant app component to make reset buttons visibility configurable, just like we have a closeBtn.

FYI - @skrishn

jmhauck commented 1 week ago

@sumitzarkar I added another boolean prop resetBtn that when false will prevent the drawing of the "Reset Filter" button in IAC 1.0.0-beta.260. It's in our develop branch now

sumitzarkar commented 1 week ago

@jmhauck

We are able to use this prop, after setting it to false the reset button is not shown. We will deliver the code in next code drop

sumitzarkar commented 1 week ago

@skrishn

Solution

Passed false value to resetBtn for the instant-apps-filter-list to hide the reset button


Dev Checklist

Items Is required Status Comments
Required NLS changes? No
Required Backward compatibility No
Required 508 No
Need Sanitize? No

Impact Analysis Report

Impacted Areas Comments
Have Configuration changes? No
Have Runtime changes? Yes
Impact on RTL No
Impact on instant app filter list Single reset button should shown at the footer of the filter list component