Esri / solutions-erg-widget

The Emergency Response Guide (ERG) widget allows users to determine potential hazards based on the type of chemical spill and user-selected location on the map.
Apache License 2.0
6 stars 4 forks source link

Remove Wind Direction Map Service Layer and associated UI/Code - It is not needed for the workflow of the widget #18

Closed Dbarnes1 closed 7 years ago

Dbarnes1 commented 7 years ago

The wind direction map service layer is referencing outdated, static sample weather data. This entire section should be cut out of the widget code and removed from the UI of the configuration page, as it is not needed to run the widget: image

The way users could get wind direction data is from running the weather station gp service or equivalent JavaScript functionality. They could also manually enter the wind direction in the widget.

Weather data is being pulled from here:
image

Manual Option: image

Classifying this as a bug.

adgiles commented 7 years ago

I agree the underlying data for this element is outdated and a bit pointless. I don't think we should remove the ability to get the current weather data all together though. We should implement the same functionality as what is in the incident analysis widget (the code is already there and should be pretty easy to implement). It is a global weather service provided by Dark Sky (https://darksky.net/) which Esri have put a front end wrapper around, so making a simple call to the following URL by changing the lat/long coords for the location you want, will provide a json response of the current and forecast weather:

http://coolmaps.esri.com/Weather/info.php?q=34.06564467337291,-117.19995147727457

I think a better workflow would be that the widget automatically tries to get the current weather data when the user selects a spill location. This can automatically set the day/night value and the wind speed. If the service can not be accessed (disadvantaged network) then the user is warned and told to manually override the values (this option should always be available anyway, for training etc..)

Dbarnes1 commented 7 years ago

Moving to verify, this issue is related to #19

Dbarnes1 commented 7 years ago

I'm going to go ahead and close this out, these layers are not a part of the latest widget.