search

Esri / solutions-erg-widget

The Emergency Response Guide (ERG) widget allows users to determine potential hazards based on the type of chemical spill and user-selected location on the map.
Apache License 2.0
6 stars 4 forks source link

Removing unnecessary files #74

Closed topowright-zz closed 6 years ago

topowright-zz commented 6 years ago

image

@adgiles, @lfunkhouser

This is the first bit of feedback from the Dev team

adgiles commented 6 years ago

@topowright The PDF’s are the pages of the ERG guide we want to link to, if we remove them that functionality will not be available.

I don’t know what the second point is referring to

llsjr2 commented 6 years ago

@topowright Agree with @adgiles The pdf files were created to provide the functionality to add the ERG book into the widget and make them readily available. It was a function that was particularly designed. https://github.com/Esri/solutions-erg-widget/issues/34

adgiles commented 6 years ago

I have checked through the images folder and found five images that were not being used. These have been removed in PR https://github.com/Esri/solutions-erg-widget/pull/75

I don't agree with the first comment that the widgets do not include png files, every core widget contains an images folder as part of the file structure. This folder structure can be seen in the developer documentation here:

https://developers.arcgis.com/web-appbuilder/guide/developer-s-guide-overview.htm

topowright-zz commented 6 years ago

verified