Feedback from Dev Group - Githubissues

Esri / solutions-erg-widget

The Emergency Response Guide (ERG) widget allows users to determine potential hazards based on the type of chemical spill and user-selected location on the map.

Apache License 2.0

6 stars 4 forks source link

Feedback from Dev Group #76

Closed topowright-zz closed 6 years ago

topowright-zz commented 6 years ago

Response from @adgiles: Done

topowright-zz commented 6 years ago

Response from @adgiles: Same file that is already released as part of the Coordinate Conversion Widget client\stemapp\widgets\CoordinateConversion\dialogConfirm.js

topowright-zz commented 6 years ago

Response from @adgiles: Released under MIT License with permission to modify: https://github.com/pawelczak/EasyAutocomplete/blob/master/LICENSE.txt

topowright-zz commented 6 years ago

Response from @adgiles: Done

topowright-zz commented 6 years ago

Response from @adgiles: This is the constructor of the coordinate utils and is passed the application utility service as a parameter (this.appConfig.geometryService). This is purely there as a catch if one is not passed.

topowright-zz commented 6 years ago

Response from @adgiles: Done

topowright-zz commented 6 years ago

Response from @adgiles: Done

topowright-zz commented 6 years ago

Response from @adgiles: @kgonzago replied https://devtopia.esri.com/WebGIS/arcgis-webappbuilder/pull/11760#discussion_r186461

topowright-zz commented 6 years ago

Response from @adgiles: Done

topowright-zz commented 6 years ago

Response from @adgiles: Repeat from above

topowright-zz commented 6 years ago

Response from @adgiles: Hard string removed as never called

adgiles commented 6 years ago

I have replied with a comment within each issue above.

Changes made in this PR https://github.com/Esri/solutions-erg-widget/pull/77

topowright-zz commented 6 years ago

verified

lfunkhouser commented 6 years ago

@topowright update the Enterprise PR with the comments from @adgiles before closing this issue.