search

Esri / solutions-erg-widget

The Emergency Response Guide (ERG) widget allows users to determine potential hazards based on the type of chemical spill and user-selected location on the map.
Apache License 2.0
6 stars 4 forks source link

Release-ready ERG #87

Closed kgonzago closed 6 years ago

kgonzago commented 6 years ago

WAB Dev team provided feedback on the widget. ERG.zip

Actions needed to complete this issue:

FYI: @topowright @dfoll @ACueva

adgiles commented 6 years ago

UI Changes addressed, latest code in https://github.com/Esri/solutions-erg-widget/tree/ag/wab-dev

@kgonzago can you move up to devtopia ASAP as there has been some string changes

kgonzago commented 6 years ago

Pushed to Devtopia in this PR

dfoll commented 6 years ago

@kgonzago @adgiles do you want me to test this, or wait until they merge into devtopia?

kgonzago commented 6 years ago

@dfoll The PR for ERG in Devtopia was merged last night. Not sure if it made it into this morning's build but may want to check if you intend to start testing.

adgiles commented 6 years ago

@topowright @dfoll @ACueva

UI changes are now showing in the daily build, good to start testing

BobBooth commented 6 years ago

Found an issue while testing where for some material types, the widget locks up, the tab goes unresponsive. https://github.com/Esri/solutions-erg-widget/issues/89

BobBooth commented 6 years ago

Widget generally looking good. Comparing widget to UI suggestions, saw a minor discrepancy. Not sure worth fixing. https://github.com/Esri/solutions-erg-widget/issues/90

BobBooth commented 6 years ago

Impeded by this issue https://github.com/Esri/solutions-erg-widget/issues/89 some material types lock up the web app. Probably related to incorrect values in the json file.

dfoll commented 6 years ago

this is still open because i have not seen #89 working dev edition daily snapshot but saw #89 working on DevExt